Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refreshing a PR doesn't refresh comments #6252

Closed
TristenFielding opened this issue Sep 25, 2024 · 1 comment · Fixed by #6257
Closed

Refreshing a PR doesn't refresh comments #6252

TristenFielding opened this issue Sep 25, 2024 · 1 comment · Fixed by #6257
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@TristenFielding
Copy link

TristenFielding commented Sep 25, 2024

Version: 1.93.1 (system setup)
Commit: 38c31bc77e0dd6ae88a4e9cc93428cc27a56ba40
Date: 2024-09-11T17:20:05.685Z
Electron: 30.4.0
ElectronBuildId: 10073054
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: 12.4.254.20-electron.0
OS: Windows_NT x64 10.0.19045
Steps to Reproduce:

  1. Start a new Review
  2. Create a comment and click on Add Review Comment.
  3. Finish the Review
  4. Externally, resolve the comment
  5. Refresh the plugin
  6. open the comment
  7. Click on the Resolve Conversation button
    1. Actual Results:
      1. Check GitHub - notice that it wasn't resolved.
      2. The GUI didn't change.
    2. Expected Results:
      1. GitHub is notified about this resolution.
      2. The comment icon should change to something different - like: image
      3. The "Resolve Conversation" button should either be disabled or changed to "Unresolve Conversation" and perhaps show a green check mark and/or a "Resolved" label at the top of the dialog box. Like so:
image
@alexr00 alexr00 self-assigned this Sep 26, 2024
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Sep 26, 2024
@alexr00 alexr00 added this to the October 2024 milestone Sep 26, 2024
@alexr00
Copy link
Member

alexr00 commented Oct 1, 2024

The only part of this I can reproduce is that using the "refresh" button on the active PR view doesn't refresh the comments.

alexr00 added a commit that referenced this issue Oct 2, 2024
alexr00 added a commit that referenced this issue Oct 2, 2024
@alexr00 alexr00 closed this as completed in 86da510 Oct 3, 2024
@justschen justschen added the verified Verification succeeded label Oct 22, 2024
@alexr00 alexr00 changed the title Resolve Conversation Button not work Refreshing a PR doesn't refresh comments Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants