Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Summary review comment buttons do not disable while review is submitting #6261

Closed
alexr00 opened this issue Oct 4, 2024 · 0 comments · Fixed by #6262
Closed

Summary review comment buttons do not disable while review is submitting #6261

alexr00 opened this issue Oct 4, 2024 · 0 comments · Fixed by #6262
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
October 2024

Comments

@alexr00
Copy link
Member

alexr00 commented Oct 4, 2024

  1. Open a PR
  2. Leave a comment on a line in the PR. Make sure to choose "Start review" rather than "Add Comment"
  3. Open the PR description and leave a comment in the input box that says "leave a review summary comment"
  4. When you click the "Request Changes", "Approve", or "Comment" buttons, they should disable while the review is submitting so you can't accidentally click them twice. After the review is submitted they don't show at all.

// cc @benibenj
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Oct 4, 2024
@alexr00 alexr00 added this to the October 2024 milestone Oct 4, 2024
@alexr00 alexr00 self-assigned this Oct 4, 2024
alexr00 added a commit that referenced this issue Oct 4, 2024
@alexr00
Summary review comment buttons do not disable while review is submitting
8ad100e 
Fixes #6261
@alexr00 alexr00 mentioned this issue Oct 4, 2024
Merged
@alexr00 alexr00 closed this as completed in 25b593b Oct 4, 2024
@rzhao271 rzhao271 added the verified Verification succeeded label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
October 2024
2 participants
@rzhao271 @alexr00