Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct permission to show 'assign yourself' in PR view sidebar #4369

Merged
merged 2 commits into from
Dec 27, 2022

Conversation

Thomas1664
Copy link
Contributor

@Thomas1664 Thomas1664 commented Dec 24, 2022

Currently, a person that created a PR is able to see the 'assign yourself' link, even if the user doesn't have the permission to assign. As a result, the user sees an error message: "Must have admin rights to Repository."

@alexr00 alexr00 self-assigned this Dec 27, 2022
@alexr00 alexr00 added this to the January 2023 milestone Dec 27, 2022
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@alexr00 alexr00 merged commit 6b505c9 into microsoft:main Dec 27, 2022
@Thomas1664 Thomas1664 deleted the assign-yourself branch December 27, 2022 10:57
eslamashour1 pushed a commit to eslamashour1/vscode-pull-request-github that referenced this pull request Dec 31, 2022
…icrosoft#4369)

* Use correct permission to show 'assign yourself' in PR view sidebar

* Fix indentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants