Reduce calls to updateState in review manager
#482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or remotes have changed
rebornix
reviewed
Sep 14, 2018
rebornix
reviewed
Sep 14, 2018
| && oldHead.type === newHead.type | ||
| && sameUpstream; | ||
|
|
||
| const sameRemotes = this._previousRepositoryState.remotes.length === this._repository.remotes.length |
There was a problem hiding this comment.
We may want to filter out remotes created for PR purpose first so a fresh checkout will only lead to one updateState, triggered by branch change.
There was a problem hiding this comment.
I'm going to hold off on making that change now, but I agree
rebornix
reviewed
Sep 14, 2018
src/view/reviewManager.ts
Outdated
|
|
||
| if (!sameHead || !sameRemotes) { | ||
| this._previousRepositoryState = { | ||
| HEAD: Object.assign(this._repository.HEAD), |
There was a problem hiding this comment.
Is object duplication necessary here? this._previousRepositoryState will keep reference to the old HEAD as when this._repository status gets updated, we will create new objects for HEAD and remotes. Correct me if I miss any potential data leak.
There was a problem hiding this comment.
Nice, you're right, no need to duplicate
rebornix
requested changes
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if
HEADandremotesare the same before callingupdateState. The equals check is a bit ugly, I didn't extract it out into a method because putting it inRepositorywould add another thing for Joao to have to implementFixes #429