Support adding/deleting reviewers and labels #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RMacfarlane
changed the title
added 5 commits
February 22, 2019 09:59
RMacfarlane
force-pushed
the
rmacfarlane/add-reviewers
branch
from
481156a
to
aad1abc
Compare
|
Run into following issues
Quickpick related
|
rebornix
reviewed
Feb 22, 2019
src/github/pullRequestManager.ts
Outdated
|
|
||
| async addLabels(pullRequest: PullRequestModel, labels: string[]): Promise<void> { | ||
| const { octokit, remote } = await pullRequest.githubRepository.ensure(); | ||
| octokit.issues.addLabels({ |
There was a problem hiding this comment.
do we want to await this call?
There was a problem hiding this comment.
yeah, nice catch
rebornix
reviewed
Feb 22, 2019
src/github/pullRequestManager.ts
Outdated
|
|
||
| async removeLabel(pullRequest: PullRequestModel, label: string): Promise<void> { | ||
| const { octokit, remote } = await pullRequest.githubRepository.ensure(); | ||
| octokit.issues.removeLabel({ |
rebornix
requested changes
Feb 22, 2019
|
Fixed the label filtering problem, the quickpick issue seems to be a problem with the webview getting refocused, so I think it might be an upstream issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #951
#412
Adding uses the quickpick:
Icon to remove appears on hover when the view is shown as a sidebar:
When the window is less than 900px wide, content looks like, with delete icons always shown:
