Ensure cancellation is supported for conda env creation.

microsoft · Feb 27, 2023 · 1eb3033 · 1eb3033
1 parent 84e3309
commit 1eb3033
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/client/pythonEnvironments/creation/provider/condaCreationProvider.ts b/src/client/pythonEnvironments/creation/provider/condaCreationProvider.ts
@@ -192,6 +192,10 @@ async function createEnvironment(options?: CreateEnvironmentOptions): Promise<Cr
                 throw ex;
             }
 
+            if (version === undefined) {
+                traceError('Python version was not selected for creating conda environment.');
+                return MultiStepAction.Cancel;
+            }
             return MultiStepAction.Continue;
         },
         undefined,

diff --git a/src/test/pythonEnvironments/creation/provider/condaCreationProvider.unit.test.ts b/src/test/pythonEnvironments/creation/provider/condaCreationProvider.unit.test.ts
@@ -76,7 +76,7 @@ suite('Conda Creation provider tests', () => {
         });
         pickPythonVersionStub.resolves(undefined);
 
-        assert.isUndefined(await condaProvider.createEnvironment());
+        await assert.isRejected(condaProvider.createEnvironment());
     });
 
     test('Create conda environment', async () => {