Skip to content

Commit

Permalink
Let pylance use SharedArrayBuffer cancellation in the browser (#21482)
Browse files Browse the repository at this point in the history
Dirk implemented a new cancellation method for the browser in the LSP
library. About 6 months ago.

We use this in the browser to provide cancellation.

Since we moved creation of the pylance language client to Python, this
is picking up the LSP library currently in the Python extension and it
was before this change by Dirk.

This change moves the LSP library up to the latest.
  • Loading branch information
rchiodo authored Jun 26, 2023
1 parent c1ff6c3 commit 9c0af35
Show file tree
Hide file tree
Showing 3 changed files with 60 additions and 66 deletions.
114 changes: 54 additions & 60 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2008,9 +2008,9 @@
"vscode-debugadapter": "^1.28.0",
"vscode-debugprotocol": "^1.28.0",
"vscode-jsonrpc": "8.0.2-next.1",
"vscode-languageclient": "8.0.2-next.5",
"vscode-languageserver": "8.0.2-next.5",
"vscode-languageserver-protocol": "3.17.2-next.6",
"vscode-languageclient": "^8.1.0",
"vscode-languageserver": "^8.1.0",
"vscode-languageserver-protocol": "^3.17.3",
"vscode-tas-client": "^0.1.63",
"which": "^2.0.2",
"winreg": "^1.2.4",
Expand Down Expand Up @@ -2038,13 +2038,13 @@
"@types/tmp": "^0.0.33",
"@types/uuid": "^8.3.4",
"@types/vscode": "^1.75.0",
"@vscode/vsce": "^2.18.0",
"@types/which": "^2.0.1",
"@types/winreg": "^1.2.30",
"@types/xml2js": "^0.4.2",
"@typescript-eslint/eslint-plugin": "^3.7.0",
"@typescript-eslint/parser": "^3.7.0",
"@vscode/test-electron": "^2.1.3",
"@vscode/vsce": "^2.18.0",
"bent": "^7.3.12",
"chai": "^4.1.2",
"chai-arrays": "^2.0.0",
Expand Down Expand Up @@ -2097,4 +2097,4 @@
"webpack-require-from": "^1.8.6",
"yargs": "^15.3.1"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export class LspInteractiveWindowMiddlewareAddon implements Middleware, Disposab
}

private static _asTextContentChange(event: TextDocumentChangeEvent, c2pConverter: Converter): TextContent {
const params = c2pConverter.asChangeTextDocumentParams(event);
const params = c2pConverter.asChangeTextDocumentParams(event, event.document.uri, event.document.version);
return { document: params.textDocument, changes: params.contentChanges };
}

Expand Down

0 comments on commit 9c0af35

Please sign in to comment.