Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: New getting started walkthrough when Python isn't installed #19549

Closed
3 tasks done
luabud opened this issue Jul 25, 2022 · 7 comments
Closed
3 tasks done

Test: New getting started walkthrough when Python isn't installed #19549

luabud opened this issue Jul 25, 2022 · 7 comments
Labels
testplan-item Test plan item/assignments for upcoming release
Milestone

Comments

@luabud
Copy link
Member

luabud commented Jul 25, 2022

Refs: #19099

Complexity: 5

Authors: @karrtikr @luabud

Create Issue


Requirements

  1. A machine with no Python installed
    • I'm not sure how to get a new macOS machine with no Python installed, but for Windows you can create one on Azure and for Linux you can just open VS Code in a devcontainer with no Python installed
  2. VS Code Insiders
  3. Pre-release version of the Python extension

Steps

  1. Open the walkthrough ("Get started... Open walkthrough" command, select "Get started with Python development")

  2. Verify that no "No Python installed" notifications pop up

  3. Verify all 4 tiles appear as expected:

    image

  4. Verify clicking on "Create Python file" creates an untitled Python file on the side:

image

  1. Verify clicking on "Select Python Interpreter" shows a "Python is not installed" option in the drop down:

    image

  2. Clicking on it will show different things depending on the OS.

    • On Windows 10/11: Click on in the "install Python" button should open the latest version of Python in the Microsoft store. After installing Python is completed, verify the interpreter shows up the next time Select Interpreter button is clicked.
    • On macOS/Linux: It should open the tile with installation instructions. Verify clicking on the "Install Python via ___" button opens a terminal and fills in the suggested commands.
@luabud luabud added the testplan-item Test plan item/assignments for upcoming release label Jul 25, 2022
@sadasant
Copy link

sadasant commented Jul 26, 2022

On Linux:

  • I used sudo mv /bin/python3 /bin/python3.bak, then sudo mv /bin/python3.8 /bin/python3.8.bak, then mv ~/anaconda3/bin/python ~/anaconda3/bin/python.bak, then mv ~/anaconda3/bin/python3 ~/anaconda3/bin/python3.bak, then mv ~/anaconda3/bin/python3.9 ~/anaconda3/bin/python3.9.bak, then code-insiders to try to start VSCode insiders without Python.
  • New window, then "Get started... Open walkthrough" then "Get started with Python development".
  • I'm not getting the "No Python installed" notifications pop up.
  • All 4 tiles appear as expected:

Screen Shot 2022-07-26 at 11 05 09 AM

  • Clicking on "Create Python file" creates an untitled Python file on the side. Also, at this point, I see a yellow "Select Interpreter" message at the bottom:

Screen Shot 2022-07-26 at 11 04 01 AM

  • By either clicking on the yellow message at the bottom, or going through the next section "Select a Python Interpreter" and clicking the "Select Python Interpreter", I get the following:

Screen Shot 2022-07-26 at 11 07 17 AM

  • Clicking on the "Python is not installed" option shows the following:
installinstructions.mov

@joyceerhl
Copy link

After installing Python via the Windows Store on a clean VM and clicking 'Select Interpreter' again, I initially get this

image

Clicking the refresh button in the top right of the quickpick results in the Windows Store Python install showing up. Not sure if that's expected?

@karrtikr
Copy link

@joyceerhl Could you please create an issue? I expect refresh to automatically be triggered when the list is opened without the need to use the refresh button.

@lszomoru
Copy link
Member

@luabud, @karrtikr uninstalling python on macOS seems like a significant undertaking.
Can any of you please provide what is the recommended way to uninstall python from a clean macOS machine?

@rzhao271 rzhao271 added this to the July 2022 milestone Jul 27, 2022
@karrtikr
Copy link

@lszomoru Can you try running Python: Select Interpreter command and delete every binary file listed there? #19550 (comment)

@lszomoru
Copy link
Member

@karrtikr, I have spent hours today trying to delete /usr/bin/python3 without any luck. I have already disabled System Integrity Protection, but I am still getting sudo chown $(whoami):admin /usr/bin/. Any recommendation on how to move forward would be appreciated. Thanks!

@karrtikr
Copy link

I see, well thanks for testing it out! I discussed it in the meeting today and python is necessary for older versions of macOS to function, so maybe that is the problem. Seems like there's no way to replicate this condition without mocking code in the extension, so for the purposes of the issue we'll consider it done. Again, thanks a lot for spending the time!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testplan-item Test plan item/assignments for upcoming release
Projects
None yet
Development

No branches or pull requests

6 participants