Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore how to notify the user they don't have Python installed when installing the Python extension for the first time #19099

Closed
brettcannon opened this issue May 9, 2022 · 5 comments · Fixed by #19379
Assignees
Labels
feature-request Request for new features or functionality meta Issue that is tracking an overall project needs proposal Need to make some design decisions needs spike Label for issues that need investigation before they can be worked on. on-testplan Added to test plan
Milestone

Comments

@brettcannon
Copy link
Member

Could have the walkthrough hide all other steps and be very clear that Python could not be found.

Should probably stop having the error notification for this.

Could wire into all the places we need Python to do something (e.g. debugging, running, etc.) and have a modal dialog telling the user to please install Python.

@brettcannon brettcannon added feature-request Request for new features or functionality meta Issue that is tracking an overall project labels May 9, 2022
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label May 9, 2022
@luabud luabud added this to the May 2022 milestone May 11, 2022
@kimadeline kimadeline added needs proposal Need to make some design decisions needs spike Label for issues that need investigation before they can be worked on. and removed triage-needed Needs assignment to the proper sub-team labels May 20, 2022
@luabud
Copy link
Member

luabud commented May 30, 2022

Once we're done with the changes, we should update our docs to reflect that (#19168)

@karrtikr
Copy link

karrtikr commented Jun 20, 2022

Options on how it indicate that through the walkthrough:

  1. Display it as a separate title and hide it once we detect no Python is installed.
    Although this would mean there's a flicker when the tile disappears.
    disappearingtile

  2. Merge it with "Select Interpreter" tile?
    That would make each step too verbose as that's a lot of a text in a single tile, also the body text could still change while the tile is opened.

  3. Show it when Python: Select Interpreter is used to open quickpick.
    installandselectinterpreter

In option 3. we need to render the markdown file similar to how getting started tile is rendered. Is it possible with markdown-it? Ideally it would be great we can simply bring Install tile to focus rather than opening a new tab.

Discussed with Luciana and decided not to go with option 3, working on a prototype for option 1 and 2 to see how it looks.

Could wire into all the places we need Python to do something (e.g. debugging, running, etc.) and have a modal dialog telling the user to please install Python.

Still planning on this.

@karrtikr
Copy link

Now that "Create Python file" is the first step, it's leading to some issues. The command for "Create Python file" is implemented by the extension which means until the extension is activated, the command does not work properly:

weirdcreatepythonfileexp

We could instead use VSCode's command to open an untitled file and direct users using that instead:

newcreatepythonfile

Ideally it would be great if VSCode itself can provide a command for creating a Python file directly.

@karrtikr
Copy link

karrtikr commented Jun 22, 2022

Opened microsoft/vscode#152920 to support #19099 (comment). Created #19380 to track it.

@karrtikr
Copy link

karrtikr commented Jul 1, 2022

  • Remove Python is not installed prompt in favor of No Interpreter Selected prompt: Improve "No Python interpreter" selected prompt #17667. This will ensure when users finish installing Python from windows store, it shows up without reload when following the prompt to open the interpreter list.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality meta Issue that is tracking an overall project needs proposal Need to make some design decisions needs spike Label for issues that need investigation before they can be worked on. on-testplan Added to test plan
Projects
None yet
5 participants