Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't send telemetry in forks #20941

Closed
brettcannon opened this issue Mar 29, 2023 · 0 comments · Fixed by #21377
Closed

Don't send telemetry in forks #20941

brettcannon opened this issue Mar 29, 2023 · 0 comments · Fixed by #21377
Assignees
@paulacamargo25
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs spike Label for issues that need investigation before they can be worked on.

Comments

@brettcannon
Copy link
Member

Since we don't know how people tweaked a fork we should probably ignore them.

I think we can set "enableTelemetry": false in package.json by default and have our release pipeline set it to true.
@brettcannon brettcannon added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-internal Label for non-user facing issues needs spike Label for issues that need investigation before they can be worked on. labels Mar 29, 2023
@paulacamargo25 paulacamargo25 self-assigned this May 4, 2023
@paulacamargo25 paulacamargo25 mentioned this issue May 4, 2023
Closed
@paulacamargo25 paulacamargo25 mentioned this issue Jun 6, 2023
Merged
paulacamargo25 added a commit that referenced this issue Jun 8, 2023
@paulacamargo25
Dont sent telemetry in forks (#21377)
3e5af44 
Closed #20941 

- Add enableTelemetry in package.json
- Add function that updates the 'enableTelemetry' value in package.json
- Update release pipelines
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@paulacamargo25 paulacamargo25

Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs spike Label for issues that need investigation before they can be worked on.
Projects
None yet
Milestone
No milestone
2 participants
@brettcannon @paulacamargo25