Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove message that just prints traceback reference for unittest error #22181

Closed
eleanorjboyd opened this issue Oct 9, 2023 · 0 comments · Fixed by #22180
Closed

remove message that just prints traceback reference for unittest error #22181

eleanorjboyd opened this issue Oct 9, 2023 · 0 comments · Fixed by #22180
Assignees
Labels
area-testing debt Covers everything internal: CI, testing, refactoring of the codebase, etc. triage-needed Needs assignment to the proper sub-team
Milestone

Comments

@eleanorjboyd
Copy link
Member

in an error for unittest run, the error message that shows up in the test result panel just includes the object reference like which isn't useful. This should no longer be printed.

@eleanorjboyd eleanorjboyd added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-testing labels Oct 9, 2023
@eleanorjboyd eleanorjboyd added this to the October 2023 milestone Oct 9, 2023
@eleanorjboyd eleanorjboyd self-assigned this Oct 9, 2023
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Oct 9, 2023
eleanorjboyd added a commit that referenced this issue Oct 10, 2023
the traceback object was incorrectly printed as just the reference to
the object in the error message. Ended up just removing it since it is
correctly printed in the traceback object which is where it should
ultimately belong. closes:
#22181

---------

Co-authored-by: Raymond Zhao <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing debt Covers everything internal: CI, testing, refactoring of the codebase, etc. triage-needed Needs assignment to the proper sub-team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant