Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.execInREPL steals shift+enter #23525

Closed
roblourens opened this issue May 29, 2024 · 3 comments · Fixed by #23526
Closed

python.execInREPL steals shift+enter #23525

roblourens opened this issue May 29, 2024 · 3 comments · Fixed by #23526
Assignees
@anthonykim1
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
May 2024

Comments

@roblourens
Copy link
Member

  • Open any text editor
  • Use shift+enter, eg when in the find widget doing "find previous"
  • A Python REPL is opened
@roblourens roblourens added the feature-request Request for new features or functionality label May 29, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label May 29, 2024
@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label May 29, 2024
@rebornix rebornix added this to the May 2024 milestone May 29, 2024
@luabud
Copy link
Member

luabud commented May 30, 2024

this is likely when python.REPL.sendToNativeREPL is set to true

@anthonykim1 anthonykim1 mentioned this issue May 30, 2024
Merged
@anthonykim1
Copy link

Thanks for the bug report, this is because I was missing some when clause for executing in native repl.
PR for fix is here: #23526

@github-actions github-actions bot added the info-needed Issue requires more information from poster label May 30, 2024
anthonykim1 added a commit that referenced this issue May 30, 2024
@anthonykim1
Bug: Fix python.execInREPL stealing shift+enter (#23526)
f001597 
Stop stealing shift+enter if editor is not focused and language is not
python.
Resolves: #23525
@anthonykim1 anthonykim1 added verification-needed Verification of issue is requested and removed triage-needed Needs assignment to the proper sub-team labels May 30, 2024
@anthonykim1
Copy link

Verification needed:

  1. Open other file editor (other than with Python language)
  2. Make sure shift+enter doesn't trigger launching Python REPL

Fix just got merged May 29th 6:21 PM, USA: PST
It should be testable after insider build tonight

@benibenj benibenj removed feature-request Request for new features or functionality info-needed Issue requires more information from poster verification-needed Verification of issue is requested labels May 30, 2024
@sandy081 sandy081 added the verified Verification succeeded label May 30, 2024
DonJayamanne pushed a commit to DonJayamanne/pythonVSCode that referenced this issue Jun 24, 2024
@anthonykim1 @DonJayamanne
Bug: Fix python.execInREPL stealing shift+enter (#23526)
025d1a6 
Stop stealing shift+enter if editor is not focused and language is not
python.
Resolves: microsoft#23525
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@anthonykim1 anthonykim1

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
May 2024
Development

Successfully merging a pull request may close this issue.

Bug: Fix python.execInREPL stealing shift+enter anthonykim1/vscode-python
6 participants
@roblourens @rebornix @sandy081 @benibenj @luabud @anthonykim1