Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop compatibility aliases. #8542

Closed
ericsnowcurrently opened this issue Nov 12, 2019 · 2 comments
Closed

Drop compatibility aliases. #8542

ericsnowcurrently opened this issue Nov 12, 2019 · 2 comments
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on

Comments

@ericsnowcurrently
Copy link
Member

(depends on PR #7915)

In #7915 I moved some things (related to fs paths) around. To avoid churn, I added some aliases. Those aliases need to be dropped and the churn incurred.

  • simply delete src/client/common/platform/pathUtils.ts
  • in src/client/common/types.ts, remove the IPathUtils and IsWindows exports
@ericsnowcurrently ericsnowcurrently added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Nov 12, 2019
@ericsnowcurrently ericsnowcurrently mentioned this issue Dec 31, 2019
Merged
ericsnowcurrently added a commit that referenced this issue Jan 8, 2020
@ericsnowcurrently
Factor out path-related classes for better testing. (#9352)
d42551a 
(for #8995)

This adds back in some of the refactored code and high-level functional tests reverted in #8970. It also adds more tests and gets things ready for #8542 (where we will drop the pathutils module, etc.).
@luabud luabud closed this as completed Dec 8, 2020
@ghost ghost removed the needs PR label Dec 8, 2020
@luabud luabud reopened this Dec 8, 2020
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Dec 8, 2020
@luabud luabud added area-internal Label for non-user facing issues needs PR and removed triage-needed Needs assignment to the proper sub-team labels Dec 8, 2020
@cpinamtz
Copy link

cpinamtz commented Jul 4, 2022

Hi, I'm stuck since the last weeks with this issue trying to compile and install successfully the extension. I began doing the substitution in launchers but I got some errors once I installed the extension.

Extension activation failed, run the 'Developer: Toggle Developer Tools' command for more information.

I also added the @injectable decorator and the Singleton statement in, I guess, the proper file, but, after compiling and installing the extension it throws in the Python console the following (compiled in webpack development mode to avoid classes renaming):

[ERROR 2022-6-4 9:23:2.116]: extension activation failed [Error: Missing required @inject or @multiInject annotation in: argument 0 in class FileSystemPathUtils.
	at getConstructorArgsAsTarget (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53994:19)
	at getConstructorArgsAsTargets (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:54006:22)
	at getTargets (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53972:30)
	at Object.getDependencies (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53957:19)
	at /home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53838:51
	at Array.forEach (<anonymous>)
	at _createSubRequests (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53826:20)
	at /home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53847:17
	at Array.forEach (<anonymous>)
	at /home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53846:26
	at Array.forEach (<anonymous>)
	at _createSubRequests (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53826:20)
	at /home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53847:17
	at Array.forEach (<anonymous>)
	at /home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53846:26
	at Array.forEach (<anonymous>)
	at _createSubRequests (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53826:20)
	at /home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53847:17
	at Array.forEach (<anonymous>)
	at /home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53846:26
	at Array.forEach (<anonymous>)
	at _createSubRequests (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53826:20)
	at Object.plan (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53868:9)
	at /home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53390:37
	at Container.__webpack_modules__../node_modules/inversify/lib/container/container.js.Container._get (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53383:44)
	at Container.__webpack_modules__../node_modules/inversify/lib/container/container.js.Container.getAll (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:53312:21)
	at ServiceContainer.getAll (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:21761:30)
	at activateLegacy (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:18585:18)
	at processTicksAndRejections (node:internal/process/task_queues:96:5)
	at async activateComponents (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:18514:36)
	at async activateUnsafe (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:114915:33)
	at async activate (/home/cpinamtz/.vscode/extensions/ms-python.python-2022.9.0-dev/out/client/extension.js:114884:42)
	at async _activate (/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:83:8180)
	at async _waitForDepsThenActivate (/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:83:8122)
	at async _initialize (/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:83:7486)]

I'm sure I'm missing something really simple but I don't know what. Thanks in advance

@github-actions github-actions bot removed the needs PR label Aug 9, 2022
@karrtikr karrtikr added the needs PR Ready to be worked on label Aug 9, 2022
@karrtikr
Copy link

This class is used in a lot of places now.

@karrtikr karrtikr closed this as not planned Won't fix, can't repro, duplicate, stale Dec 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ericsnowcurrently @cpinamtz @karrtikr @luabud