forked from DonJayamanne/pythonVSCode
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VS Python analysis engine integration #1231
Merged
Merged
Changes from all commits
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
a764bc9
Undo changes
9d1b2cc
Test fixes
a91291a
Increase timeout
bf266af
Remove double event listening
7bc6bd6
Remove test
8ce8b48
Revert "Remove test"
e3a549e
Revert "Remove double event listening"
c879aa6
Undo changes
716968f
Test fixes
63a1385
.NET Core check
7ea7717
Better find dotnet
75be0da
Fix pip test
2701768
Linting tests
a22e705
Undo accidental changes
5441644
Add clone and build PTVS
97175e1
Appveyor PTVS build
1e97e6a
Fix slashes
86ac269
Enable build
7b4e73c
Try absolute path
bd1fd77
Fix xcopy switch
72b91f1
Activate Analysis Engine test on Appveyor
e32320b
Temporary only run new tests
55bb349
Disable PEP hint tests
3826ffa
Test fix
b62ba25
Disable appveyor build and tests for PTVS for now
a13770b
Remove analysis engine test from the set
ac646c8
Remove VS image for now
f754812
Build/sign VSXI project
826dcee
Run vsce from cmd
8cb0c44
Rename
05d4d23
Abs path vsce
7fd6a8b
Path
bbcc65d
Move project
8d170c0
Ignore publishing project
869b38c
Try csproj
d8c80f6
Add framework
56e6b56
Ignore build output folder
ce6b360
Package before build
a7847d8
Try batch instead of PS
05c0bf0
Fix path quotes
92e8c1e
#1096 The if statement is automatically formatted incorrectly
b540a1d
Merge fix
7b0573e
Add more tests
facb106
More tests
f113881
Typo
3e76718
Test
6e85dc6
Also better handle multiline arguments
3e071e0
Changes lost on squash
818a46f
More lost changes
ac97532
Restore Jedi/PTVS setting
395b96a
Merge branch 'master' into vsc
54a090b
Update tests to new PTVS
3f74686
Signature tests
febb828
Merge master
355edfb
Add PTVS tests task
ccc1017
Analysis Engine contribution
5c87964
Add Mac/Linux info
68e3384
Disable csproj build
abb3daa
Add unzip to dependencies
78fd495
Minor fixes to doc
9b9b51c
Merge branch 'master' of https://github.com/Microsoft/vscode-python i…
84c8b0f
Change setting type to bool
7761a15
Report progress on status bar
240d26f
Simplify
736846a
CR feedback
1c73143
Merge branch 'vsc' of https://github.com/MikhailArkhipov/vscode-pytho…
f03c18a
Fix launching fx-independent code on Mac/Linux
70ce69b
Add title
c33ae8d
Proper download when .NET is missing
be268fb
Merge branch 'vsc' of https://github.com/MikhailArkhipov/vscode-pytho…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,3 +16,5 @@ coverage/ | |
pythonFiles/experimental/ptvsd/** | ||
debug_coverage*/** | ||
analysis/** | ||
bin/** | ||
obj/** |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
# Contributing to Microsoft Python Analysis Engine | ||
[![Contributing to Python Tools for Visual Studio](https://github.com/Microsoft/PTVS/blob/master/CONTRIBUTING.md)] | ||
|
||
[![Build Status (Travis)](https://travis-ci.org/Microsoft/vscode-python.svg?branch=master)](https://travis-ci.org/Microsoft/vscode-python) [![Build status (AppVeyor)](https://ci.appveyor.com/api/projects/status/s0pt8d79gqw222j7?svg=true)](https://ci.appveyor.com/project/DonJayamanne/vscode-python-v3vd6) [![codecov](https://codecov.io/gh/Microsoft/vscode-python/branch/master/graph/badge.svg)](https://codecov.io/gh/Microsoft/vscode-python) | ||
|
||
|
||
## Contributing a pull request | ||
|
||
### Prerequisites | ||
|
||
1. .NET Core 2.0+ SDK | ||
- [Windows](https://www.microsoft.com/net/learn/get-started/windows) | ||
- [Mac OS](https://www.microsoft.com/net/learn/get-started/macos) | ||
- [Linux](https://www.microsoft.com/net/learn/get-started/linux/rhel) | ||
2. C# Extension to VS Code (all platforms) | ||
3. Python 2.7 | ||
4. Python 3.6 | ||
|
||
*Alternative:* [Visual Studio 2017](https://www.visualstudio.com/downloads/) (Windows only) with .NET Core and C# Workloads. Community Edition is free and is fully functional. | ||
|
||
### Setup | ||
|
||
```shell | ||
git clone https://github.com/microsoft/ptvs | ||
cd Python/Product/VsCode/AnalysisVsc | ||
dotnet build | ||
``` | ||
|
||
Visual Studio 2017: | ||
1. Open solution in Python/Product/VsCode | ||
2. Build AnalysisVsc project | ||
3. Binaries arrive in *Python/BuildOutput/VsCode/raw* | ||
4. Delete contents of the *analysis* folder in the Python Extension folder | ||
5. Copy *.dll, *.pdb, *.json fron *Python/BuildOutput/VsCode/raw* to *analysis* | ||
|
||
### Debugging code in Python Extension to VS Code | ||
Folow regular TypeScript debugging steps | ||
|
||
### Debugging C# code in Python Analysis Engine | ||
1. Launch another instance of VS Code | ||
2. Open Python/Product/VsCode/AnalysisVsc folder | ||
3. Python Analysis Engine code is in *Python/Product/VsCode/Analysis* | ||
4. Run extension from VS Code | ||
5. In the instance with C# code select Dotnet Attach launch task. | ||
6. Attach to *dotnet* process running *Microsoft.PythonTools.VsCode.dll* | ||
|
||
On Windows you can also attach from Visual Studio 2017. | ||
|
||
### Validate your changes | ||
|
||
1. Build C# code | ||
2. Copy binaries to *analysis* folder | ||
3. Use the `Launch Extension` launch option. | ||
|
||
### Unit Tests | ||
1. Run the Unit Tests via the `Launch Analysis Engine Tests`. | ||
2. On Windows you can also open complete PTVS solution in Visual Studio and run its tests (or at least the Analysis section). | ||
|
||
|
||
### Coding Standards | ||
See [![Contributing to Python Tools for Visual Studio](https://github.com/Microsoft/PTVS/blob/master/CONTRIBUTING.md)] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
%1\vsce package --out %2 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't remember, but please could you confirm that the tests only run on Appveyor and not on Travis. If this is true, then we might want to create an issue for this, to ensure we try to get this resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They currently only on Appveyor b/c of setup issues. We need to discuss if we want a) install .NET Runtime on Travis or b) rely on some other means. (b) may work for us as we download from Azure but third party contributors cant.