Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new Python file command #18522

Merged
merged 19 commits into from
Feb 23, 2022
Merged

Create new Python file command #18522

merged 19 commits into from
Feb 23, 2022

Conversation

luabud
Copy link
Member

@luabud luabud commented Feb 15, 2022

For #18376

@luabud luabud added the skip package*.json package.json and package-lock.json don't both need updating label Feb 15, 2022
@luabud luabud marked this pull request as ready for review February 16, 2022 23:24
@luabud
Copy link
Member Author

luabud commented Feb 17, 2022

For the failed tests:

image

package.json Outdated Show resolved Hide resolved
Copy link

@kimadeline kimadeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊

@brettcannon brettcannon removed their request for review February 22, 2022 20:18
Co-authored-by: Kim-Adeline Miguel <[email protected]>
@luabud luabud merged commit 273cf57 into microsoft:main Feb 23, 2022
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
* Create new Python file command

* Rename command

* Format documents

* Add a news entry

* Add telemetry and add experimental setting

* Add tests

* Format document

* Disable eslint class-methods-use-this

* Attempt to fix test

* Add workspace service

* Try to fix test again

* Fix tests and add appShell

* Add title for command

* Add titles to package.nls.json

* Remove accidental launch.json edit

* Apply suggestions from code review

Co-authored-by: Kartik Raj <[email protected]>

* Add shorttitle to new file command

* Apply suggestions from code review

Co-authored-by: Kim-Adeline Miguel <[email protected]>

Co-authored-by: Kartik Raj <[email protected]>
Co-authored-by: Kim-Adeline Miguel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip package*.json package.json and package-lock.json don't both need updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants