Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use -I flag in case we're unable to find encodings module when validating python #20803

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Do not use -I flag in case we're unable to find encodings module when validating python #20803

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/client/pythonEnvironments/base/info/environmentInfoService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,11 +169,16 @@ class EnvironmentInfoService implements IEnvironmentInfoService {
return undefined;
});
} else if (reason) {
if (reason.message.includes('Unknown option: -I')) {
if (
reason.message.includes('Unknown option: -I') ||
reason.message.includes("ModuleNotFoundError: No module named 'encodings'")
Comment on lines +173 to +174
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that if the user's OS/VS Code are in a language other than English, that these error messages are still in English?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, cc/ @brettcannon

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, we don't localize (at least in CPython which is the most common implementation). If you wanted to be really safe you could check for ModuleNotFoundError and encodings as those are names of specific things and thus can't be translated.

) {
traceWarn(reason);
traceError(
'Support for Python 2.7 has been dropped by the Python extension so certain features may not work, upgrade to using Python 3.',
);
if (reason.message.includes('Unknown option: -I')) {
traceError(
'Support for Python 2.7 has been dropped by the Python extension so certain features may not work, upgrade to using Python 3.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this is to be surfaced to the user, it should probably be localized. If it's only for logs, then it shouldn't.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's only for the logs.

);
}
return buildEnvironmentInfo(env, false).catch((err) => {
traceError(err);
return undefined;
Expand Down