Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that errors on repeat folder name #21433

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

eleanorjboyd
Copy link
Member

fixes #21423

fixes so the dictionary that stores the folders created so far in the plugin architecture is using the folder path as the key instead of folder name so the key is always unique.

@eleanorjboyd eleanorjboyd added bug Issue identified by VS Code Team member as probable bug area-testing labels Jun 14, 2023
@eleanorjboyd eleanorjboyd self-assigned this Jun 14, 2023
@eleanorjboyd eleanorjboyd marked this pull request as ready for review June 14, 2023 19:58
@karthiknadig karthiknadig changed the title fix bug that errors on repeat folder name Fix bug that errors on repeat folder name Jun 14, 2023
@eleanorjboyd eleanorjboyd merged commit 88e2ef5 into microsoft:main Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-testing bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test discovery in pythonTestAdapter experiment breaks if folder names repeat
2 participants