Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update writing style based on recommendation #21525

Merged
merged 8 commits into from
Jul 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions src/client/common/utils/localize.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ export namespace Common {
export const close = l10n.t('Close');
export const bannerLabelYes = l10n.t('Yes');
export const bannerLabelNo = l10n.t('No');
export const yesPlease = l10n.t('Yes, please');
export const canceled = l10n.t('Canceled');
export const cancel = l10n.t('Cancel');
export const ok = l10n.t('Ok');
Expand Down Expand Up @@ -143,7 +142,7 @@ export namespace TensorBoard {
export const launchNativeTensorBoardSessionCodeLens = l10n.t('▶ Launch TensorBoard Session');
export const launchNativeTensorBoardSessionCodeAction = l10n.t('Launch TensorBoard session');
export const missingSourceFile = l10n.t(
'We could not locate the requested source file on disk. Please manually specify the file.',
'The Python extension could not locate the requested source file on disk. Please manually specify the file.',
);
export const selectMissingSourceFile = l10n.t('Choose File');
export const selectMissingSourceFileDescription = l10n.t(
Expand All @@ -167,7 +166,7 @@ export namespace LanguageService {
);

export const reloadAfterLanguageServerChange = l10n.t(
'Please reload the window switching between language servers.',
'Reload the window after switching between language servers.',
);

export const lsFailedToStart = l10n.t(
Expand All @@ -184,7 +183,7 @@ export namespace LanguageService {
export const extractionCompletedOutputMessage = l10n.t('Language server download complete.');
export const extractionDoneOutputMessage = l10n.t('done.');
export const reloadVSCodeIfSeachPathHasChanged = l10n.t(
'Search paths have changed for this Python interpreter. Please reload the extension to ensure that the IntelliSense works correctly.',
'Search paths have changed for this Python interpreter. Reload the extension to ensure that the IntelliSense works correctly.',
);
}
export namespace Interpreters {
Expand All @@ -211,11 +210,11 @@ export namespace Interpreters {
'Tip: you can change the Python interpreter used by the Python extension by clicking on the Python version in the status bar',
);
export const installPythonTerminalMessageLinux = l10n.t(
'💡 Please try installing the Python package using your package manager. Alternatively you can also download it from https://www.python.org/downloads',
'💡 Try installing the Python package using your package manager. Alternatively you can also download it from https://www.python.org/downloads',
);

export const installPythonTerminalMacMessage = l10n.t(
'💡 Brew does not seem to be available. Please try to download Python from https://www.python.org/downloads. Alternatively, you can install the Python package using some other available package manager.',
'💡 Brew does not seem to be available. You can download Python from https://www.python.org/downloads. Alternatively, you can install the Python package using some other available package manager.',
);
export const changePythonInterpreter = l10n.t('Change Python Interpreter');
export const selectedPythonInterpreter = l10n.t('Selected Python Interpreter');
Expand All @@ -225,7 +224,7 @@ export namespace InterpreterQuickPickList {
export const condaEnvWithoutPythonTooltip = l10n.t(
'Python is not available in this environment, it will automatically be installed upon selecting it',
);
export const noPythonInstalled = l10n.t('Python is not installed, please download and install it');
export const noPythonInstalled = l10n.t('Python is not installed');
export const clickForInstructions = l10n.t('Click for instructions...');
export const globalGroupName = l10n.t('Global');
export const workspaceGroupName = l10n.t('Workspace');
Expand Down Expand Up @@ -266,7 +265,7 @@ export namespace Installer {

export namespace ExtensionSurveyBanner {
export const bannerMessage = l10n.t(
'Can you please take 2 minutes to tell us how the Python extension is working for you?',
'Can you take 2 minutes to tell us how the Python extension is working for you?',
karthiknadig marked this conversation as resolved.
Show resolved Hide resolved
);
export const bannerLabelYes = l10n.t('Yes, take survey now');
export const bannerLabelNo = l10n.t('No, thanks');
Expand Down Expand Up @@ -418,7 +417,7 @@ export namespace Testing {

export namespace OutdatedDebugger {
export const outdatedDebuggerMessage = l10n.t(
'We noticed you are attaching to ptvsd (Python debugger), which was deprecated on May 1st, 2020. Please switch to [debugpy](https://aka.ms/migrateToDebugpy).',
'We noticed you are attaching to ptvsd (Python debugger), which was deprecated on May 1st, 2020. Use [debugpy](https://aka.ms/migrateToDebugpy) instead.',
);
}

Expand All @@ -435,13 +434,13 @@ export namespace SwitchToDefaultLS {
}

export namespace CreateEnv {
export const informEnvCreation = l10n.t('We have selected the following environment:');
export const informEnvCreation = l10n.t('The following environment is selected:');
export const statusTitle = l10n.t('Creating environment');
export const statusStarting = l10n.t('Starting...');

export const hasVirtualEnv = l10n.t('Workspace folder contains a virtual environment');

export const noWorkspace = l10n.t('Please open a folder when creating an environment using venv.');
export const noWorkspace = l10n.t('A workspace is required when creating an environment using venv.');

export const pickWorkspacePlaceholder = l10n.t('Select a workspace to create environment');

Expand All @@ -465,12 +464,12 @@ export namespace CreateEnv {
}

export namespace Conda {
export const condaMissing = l10n.t('Please install `conda` to create conda environments.');
export const condaMissing = l10n.t('Install `conda` to create conda environments.');
export const created = l10n.t('Environment created...');
export const installingPackages = l10n.t('Installing packages...');
export const errorCreatingEnvironment = l10n.t('Error while creating conda environment.');
export const selectPythonQuickPickPlaceholder = l10n.t(
'Please select the version of Python to install in the environment',
'Select the version of Python to install in the environment',
);
export const creating = l10n.t('Creating conda environment...');
export const providerDescription = l10n.t('Creates a `.conda` Conda environment in the current workspace');
Expand All @@ -485,7 +484,7 @@ export namespace ToolsExtensions {
'Use the Pylint extension to enable easier configuration and new features such as quick fixes.',
);
export const isortPromptMessage = l10n.t(
'To use sort imports, please install the isort extension. It provides easier configuration and new features such as code actions.',
'To use sort imports, install the isort extension. It provides easier configuration and new features such as code actions.',
);
export const installPylintExtension = l10n.t('Install Pylint extension');
export const installFlake8Extension = l10n.t('Install Flake8 extension');
Expand Down
2 changes: 1 addition & 1 deletion src/client/debugger/extension/adapter/factory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,6 @@ export class DebugAdapterDescriptorFactory implements IDebugAdapterDescriptorFac
* @memberof DebugAdapterDescriptorFactory
*/
private async notifySelectInterpreter() {
await showErrorMessage(l10n.t('Please install Python or select a Python Interpreter to use the debugger.'));
await showErrorMessage(l10n.t('Install Python or select a Python Interpreter to use the debugger.'));
}
}
Loading