Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix to get user defined env and use it to set up testing subprocess #22165

Merged
merged 2 commits into from
Oct 6, 2023
Merged

fix to get user defined env and use it to set up testing subprocess #22165

merged 2 commits into from
Oct 6, 2023

Conversation

eleanorjboyd
Copy link
Member

@eleanorjboyd eleanorjboyd commented Oct 6, 2023 •
edited
Loading

fixes #21642 and #22166

@eleanorjboyd eleanorjboyd added bug Issue identified by VS Code Team member as probable bug area-testing labels Oct 6, 2023
@eleanorjboyd eleanorjboyd self-assigned this Oct 6, 2023
karrtikr
karrtikr previously approved these changes Oct 6, 2023
View reviewed changes
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to have a meaningful title when adding stuff to changelog, and add milestone with appropriate labels for the issue being closed so they can be verified.

@eleanorjboyd eleanorjboyd changed the title get env and pass to test setup fix to get user defined env and use it to set up testing subprocess Oct 6, 2023
@eleanorjboyd eleanorjboyd merged commit e7dfef8 into microsoft:main Oct 6, 2023
29 checks passed
@eleanorjboyd eleanorjboyd deleted the get-env-vars branch October 6, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karrtikr karrtikr karrtikr approved these changes

@karthiknadig karthiknadig Awaiting requested review from karthiknadig

@paulacamargo25 paulacamargo25 Awaiting requested review from paulacamargo25

@anthonykim1 anthonykim1 Awaiting requested review from anthonykim1

Assignees

@eleanorjboyd eleanorjboyd

Labels
area-testing bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python Tests fails to load PYTHONPATH
2 participants
@eleanorjboyd @karrtikr