Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump vscode-tas-client and fix tests #22493

Merged
merged 2 commits into from
Nov 18, 2023
Merged

Bump vscode-tas-client and fix tests #22493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3f5e56
Bump and fix `vscode-tas-client`
karthiknadig Nov 18, 2023
2718742
Add comment
karthiknadig Nov 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 45 additions & 51 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1588,7 +1588,7 @@
"vscode-jsonrpc": "^8.2.0",
"vscode-languageclient": "^9.0.1",
"vscode-languageserver-protocol": "^3.17.5",
"vscode-tas-client": "^0.1.63",
"vscode-tas-client": "^0.1.75",
"which": "^2.0.2",
"winreg": "^1.2.4",
"xml2js": "^0.5.0"
Expand Down
10 changes: 6 additions & 4 deletions src/test/common/experiments/service.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ import { assert } from 'chai';
import * as sinon from 'sinon';
import { anything, instance, mock, when } from 'ts-mockito';
import { Disposable } from 'vscode-jsonrpc';
import * as tasClient from 'vscode-tas-client';
// sinon can not create a stub if we just point to the exported module
import * as tasClient from 'vscode-tas-client/vscode-tas-client/VSCodeTasClient';
import * as expService from 'vscode-tas-client';
import { ApplicationEnvironment } from '../../../client/common/application/applicationEnvironment';
import { IApplicationEnvironment, IWorkspaceService } from '../../../client/common/application/types';
import { WorkspaceService } from '../../../client/common/application/workspace';
Expand Down Expand Up @@ -180,7 +182,7 @@ suite('Experimentation service', () => {
getTreatmentVariable = sinon.stub().returns(true);
sinon.stub(tasClient, 'getExperimentationService').returns(({
getTreatmentVariable,
} as unknown) as tasClient.IExperimentationService);
} as unknown) as expService.IExperimentationService);

configureApplicationEnvironment('stable', extensionVersion);
});
Expand Down Expand Up @@ -218,7 +220,7 @@ suite('Experimentation service', () => {
getTreatmentVariable = sinon.stub().returns(false);
sinon.stub(tasClient, 'getExperimentationService').returns(({
getTreatmentVariable,
} as unknown) as tasClient.IExperimentationService);
} as unknown) as expService.IExperimentationService);

configureApplicationEnvironment('stable', extensionVersion);

Expand Down Expand Up @@ -364,7 +366,7 @@ suite('Experimentation service', () => {
getTreatmentVariableStub = sinon.stub().returns(Promise.resolve('value'));
sinon.stub(tasClient, 'getExperimentationService').returns(({
getTreatmentVariable: getTreatmentVariableStub,
} as unknown) as tasClient.IExperimentationService);
} as unknown) as expService.IExperimentationService);

configureApplicationEnvironment('stable', extensionVersion);
});
Expand Down
Loading