Hide Run Python option when in Jupyter Notebook #23732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonykim1
added
debt
karthiknadig
previously approved these changes
Jul 3, 2024
rebornix
reviewed
Jul 3, 2024
package.json
Outdated
| @@ -1361,7 +1361,7 @@ | |||
| { | |||
| "submenu": "python.run", | |||
| "group": "Python", | |||
| "when": "editorLangId == python && !virtualWorkspace && shellExecutionSupported && isWorkspaceTrusted" | |||
| "when": "editorLangId == python && !virtualWorkspace && shellExecutionSupported && isWorkspaceTrusted && !jupyter.ownsSelection && !notebookEditorFocused " | |||
There was a problem hiding this comment.
there is an additional whitespace at the end. Also I wonder if !notebookEditorFocused is sufficient as we just want to filter out all notebooks.
If we only want to filter out Jupyter notebook, but not necessarily other custom notebook (including repl), then the check is notebookType != jupyter-notebook
There was a problem hiding this comment.
thanks for input! Just made changes to 4ac4ab3 adding notebookType != jupyter-notebook to only exclude notebook and include REPL
paulacamargo25
approved these changes
Jul 9, 2024
eleanorjboyd
pushed a commit
to eleanorjboyd/vscode-python
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #22739