Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detect if we are installing musl or gnu target #25

Merged
merged 1 commit into from
Sep 30, 2021
Merged

detect if we are installing musl or gnu target #25

merged 1 commit into from
Sep 30, 2021

Conversation

TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Sep 30, 2021 •
edited
Loading

@TylerLeonhardt TylerLeonhardt self-assigned this Sep 30, 2021
@TylerLeonhardt TylerLeonhardt changed the title detect if we are installing in musl or gnu detect if we are installing musl or gnu target Sep 30, 2021
roblourens
roblourens approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, assuming you tried it and it works

deepak1556
deepak1556 approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we only want to target this fix for Alpine then we could read cat /etc/os-release, otherwise this works as well.

@roblourens roblourens merged commit 6660286 into main Sep 30, 2021
@roblourens roblourens deleted the TylerLeonhardt/musl-support branch September 30, 2021 23:35
@matteosacchetto matteosacchetto mentioned this pull request Dec 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@roblourens roblourens roblourens approved these changes

Assignees

@TylerLeonhardt TylerLeonhardt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alpine ARM64 - Search and file quick pick is broken
3 participants
@TylerLeonhardt @roblourens @deepak1556