-
Notifications
You must be signed in to change notification settings - Fork 29.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
watcher - implement and adopt universal file watcher
- Loading branch information
Showing
21 changed files
with
1,229 additions
and
911 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
b03fe7a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sandy081 fyi this has an impact on non-recursive watching where you are I think the only customer so far for configuration service
Before
Any request to watch a folder/file non-recursively was send to the main process and then handled via
fs.watch
.Now
Any request to watch a folder/file non-recursively is now handled like the recursive requests in a node.js enabled worker from the shared process but still via
fs.watch
. The only difference is that requests to the same path will now be ignored from the same window.The gist of this change is to make sure that any file watching from a window is not making the main process busy but is always handled from a separate process, even if the watch request is non-recursive.
Maybe you could give this a quick smoke test for your listeners, thanks.
b03fe7a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I assume you will be having a TPI for this and please add me as one of the assigners (in Mac) so that I will also test config change listeners
b03fe7a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, done in #140693