Skip to content

Commit

Permalink
fix #54545
Browse files Browse the repository at this point in the history
  • Loading branch information
jrieken committed Aug 6, 2018
1 parent 2c070ce commit c0917d8
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/vs/editor/contrib/suggest/suggestModel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,9 @@ export class SuggestModel implements IDisposable {
this._updateTriggerCharacters();
this.cancel();
}));
this._toDispose.push(this._editor.onDidBlurEditorText(() => {
this.cancel();

This comment has been minimized.

Copy link
@ramya-rao-a

ramya-rao-a Aug 10, 2018

Contributor

@jrieken This breaks the "sticky" feature of the suggest widget that we use for development purposes as we never reach https://github.com/Microsoft/vscode/blob/52ed999139d8c10d3e8ee003d8a6336a9c1d1fa7/src/vs/editor/contrib/suggest/suggestWidget.ts#L484

This comment has been minimized.

Copy link
@ramya-rao-a

ramya-rao-a Aug 10, 2018

Contributor

PR #56123 to bring sticky back

This comment has been minimized.

Copy link
@jrieken

jrieken Aug 10, 2018

Author Member

wasn't aware of a sticky feature...

}));
this._toDispose.push(this._editor.onDidChangeConfiguration(() => {
this._updateTriggerCharacters();
this._updateQuickSuggest();
Expand Down

0 comments on commit c0917d8

Please sign in to comment.