Skip to content

Commit

Permalink
Ignore position parameter for now when laying out notebook widget (#1…
Browse files Browse the repository at this point in the history
…67759)

Ignore position parameter for now

Fixes #167087

As discussed in #167087 (comment), the position is sometimes incorrect. Since we are close to release, the safest fix is to ignore this position. We can look into fixing the position for december
  • Loading branch information
mjbvz authored Nov 30, 2022
1 parent e841339 commit cec4114
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1700,7 +1700,7 @@ export class NotebookEditorWidget extends Disposable implements INotebookEditorD
return this._scrollBeyondLastLine && !this.isEmbedded;
}

layout(dimension: DOM.Dimension, shadowElement?: HTMLElement, position?: DOM.IDomPosition): void {
layout(dimension: DOM.Dimension, shadowElement?: HTMLElement, _position?: DOM.IDomPosition): void {
if (!shadowElement && this._shadowElementViewInfo === null) {
this._dimension = dimension;
return;
Expand All @@ -1712,7 +1712,7 @@ export class NotebookEditorWidget extends Disposable implements INotebookEditorD
}

if (shadowElement) {
this.updateShadowElement(shadowElement, dimension, position);
this.updateShadowElement(shadowElement, dimension, /*position*/ undefined);
}

if (this._shadowElementViewInfo && this._shadowElementViewInfo.width <= 0 && this._shadowElementViewInfo.height <= 0) {
Expand Down Expand Up @@ -1741,7 +1741,7 @@ export class NotebookEditorWidget extends Disposable implements INotebookEditorD
this._overlayContainer.style.position = 'absolute';
this._overlayContainer.style.overflow = 'hidden';

this.layoutContainerOverShadowElement(dimension, position);
this.layoutContainerOverShadowElement(dimension, /*position*/ undefined);

if (this._webviewTransparentCover) {
this._webviewTransparentCover.style.height = `${dimension.height}px`;
Expand Down

0 comments on commit cec4114

Please sign in to comment.