Fixes #79966: Remove inline icons from keybindings.json info/errors

microsoft · Aug 29, 2019 · ec3296d · ec3296d
1 parent f175024
commit ec3296d
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 22 deletions.
diff --git a/src/vs/workbench/contrib/preferences/browser/keybindingsEditorContribution.ts b/src/vs/workbench/contrib/preferences/browser/keybindingsEditorContribution.ts
@@ -302,14 +302,12 @@ export class KeybindingEditorDecorationsRenderer extends Disposable {
 	private _createDecoration(isError: boolean, uiLabel: string | null, usLabel: string | null, model: ITextModel, keyNode: Node): IModelDeltaDecoration {
 		let msg: MarkdownString;
 		let className: string;
-		let beforeContentClassName: string;
 		let overviewRulerColor: ThemeColor;
 
 		if (isError) {
 			// this is the error case
 			msg = new MarkdownString().appendText(NLS_KB_LAYOUT_ERROR_MESSAGE);
 			className = 'keybindingError';
-			beforeContentClassName = 'inlineKeybindingError';
 			overviewRulerColor = themeColorFromId(overviewRulerError);
 		} else {
 			// this is the info case
@@ -335,7 +333,6 @@ export class KeybindingEditorDecorationsRenderer extends Disposable {
 				);
 			}
 			className = 'keybindingInfo';
-			beforeContentClassName = 'inlineKeybindingInfo';
 			overviewRulerColor = themeColorFromId(overviewRulerInfo);
 		}
 
@@ -352,7 +349,6 @@ export class KeybindingEditorDecorationsRenderer extends Disposable {
 			options: {
 				stickiness: TrackedRangeStickiness.NeverGrowsWhenTypingAtEdges,
 				className: className,
-				beforeContentClassName: beforeContentClassName,
 				hoverMessage: msg,
 				overviewRuler: {
 					color: overviewRulerColor,

diff --git a/src/vs/workbench/contrib/preferences/browser/media/keybindings.css b/src/vs/workbench/contrib/preferences/browser/media/keybindings.css
@@ -41,24 +41,6 @@
 }
 
 /* Editor decorations */
-.monaco-editor .inlineKeybindingInfo:before {
-	margin: 0.2em 0.1em 0 0.1em;
-	content:" ";
-	display:inline-block;
-	height:0.8em;
-	width:1em;
-	background-size: 0.9em;
-}
-
-.monaco-editor .inlineKeybindingError:before {
-	margin: 0.1em 0.1em 0 0.1em;
-	content:" ";
-	display:inline-block;
-	height:0.8em;
-	width:1em;
-	background-size: 1em;
-}
-
 .monaco-editor .keybindingInfo {
 	box-shadow:	inset 0 0 0 1px #B9B9B9;
 	background-color: rgba(100, 100, 250, 0.2);