Extend language API to allow sourceRange in Go to Definition

[vidhya03]

• VSCode Version: Code 1.3.1 (e6b4afa, 2016-07-12T13:35:06.227Z)
• OS Version: Windows_NT ia32 6.1.7601

Steps to Reproduce:

1. Create a typescript project for eg angular2
2. create a component with name having dot character
3. import the module in to another component.

ctrl + hover - highlighting upto dot character
in the below issue the ctl + hover should highlight gateway.destination.component but it is highlighting only the component alone.

[dbaeumer]

This is the link detector / renderer in the editor. The tsserver returns the right result for the definition request. @alexandrudima assuming this is you. Please move back if I am mistaken.

[alexdima]

I think it is a limitation of DefinitionProvider that does not return the source range, it only returns the definition ranges.

[alexdima]

fyi @bpasero @jrieken

[bpasero]

Yes, I am getting the target location and so the link is being created around the word you hover over. We have the same issue in selfhost when hovering over imports too.

See https://github.com/Microsoft/vscode/blob/master/src/vs/editor/contrib/goToDeclaration/browser/goToDeclaration.ts#L276

[jrieken]

@bpasero You could maybe not use the word but the token? Then it would be the whole string token instead of the string in there?

[bpasero]

@jrieken is there API for me to get this info? I can give it a try 👍

[jrieken]

Yeah - I believe you use getLineToken-method and continue from there

[bpasero]

I cannot use tokens because some languages return a lot more in a single token compared to what you can click on. For example for a TS thing like QUnit.equal(entry, entry.next); the token includes QUnit, equal and even the whitespace to the left.

I think the lack of token info here was the original reason why we went with words.

[alexdima]

I think this would go well only if the GoToDefinition result would include a sourceRange or something that could be used for highlighting. Relying on the tokens has the exact same kind of issues as relying on the word.

[dbaeumer]

@jrieken @ben: who should own this. To my knowledge the API doesn't allow to return the information and the tsserver doesn't provide it.

[jrieken]

No language service I know off provides that information. I still believe that tokens are the way to go but 'yes' it does depend on how good/bad those are. If we extend the API to allow for a source range we still need to handle the missing case.

[bpasero]

As of today using tokens is worse than using words :)

[mjbvz]

Upstream change from TS to support this: microsoft/TypeScript#19175