Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate file system provider changes in opened editors #110854

Closed
bpasero opened this issue Nov 18, 2020 · 1 comment
Closed

Investigate file system provider changes in opened editors #110854

bpasero opened this issue Nov 18, 2020 · 1 comment
Assignees
@bpasero
Labels
debt Code quality issues file-io File I/O insiders-released Patch has been released in VS Code Insiders workbench-editors Managing of editor widgets in workbench window
Milestone
November 2020

Comments

@bpasero
Copy link
Member

bpasero commented Nov 18, 2020

I do think it is fishy that editor don't update/change when the filesystem provider goes (and returns). Adding @bpasero what the semantics are supposed to be. I think unregistering a file system provider is similar to cases where files are deleted on disk, when a new provider for the same scheme return the editor should probably update.

For readonly-ness we also have #73122 which is about readonly-ness on the level of a file

Originally posted by @jrieken in #109527 (comment)
@bpasero bpasero mentioned this issue Nov 18, 2020
Closed
@bpasero bpasero self-assigned this Nov 18, 2020
@bpasero bpasero added debt Code quality issues file-io File I/O workbench-editors Managing of editor widgets in workbench window labels Nov 18, 2020
@bpasero bpasero added this to the On Deck milestone Nov 18, 2020
@bpasero bpasero modified the milestones: On Deck, November 2020 Nov 19, 2020
@jrieken
Copy link
Member

jrieken commented Nov 19, 2020

👏

chenjigeng pushed a commit to chenjigeng/vscode that referenced this issue Nov 22, 2020
@bpasero
editors - update readonly options when file providers change (fix mic…
0d2eaf6 
…rosoft#110854)
@gjsjohnmurray gjsjohnmurray mentioned this issue Nov 25, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
debt Code quality issues file-io File I/O insiders-released Patch has been released in VS Code Insiders workbench-editors Managing of editor widgets in workbench window
Projects
None yet
Milestone
November 2020
Development

No branches or pull requests
3 participants
@bpasero @jrieken and others