Debug Auto Attach: introduce an option to disable without hiding status bar item

[weinand]

Currently we have these Auto Attach settings:

What I think is missing is a setting that disables Auto Attach but continues to show it in the status bar.
Sometimes I just want to disable Auto Attach temporarily but since the status bar item is gone, I forget to enable it again...

I think we have two options to achieve this:

• we just add a new value "Off" (or "Never" if we want to match "Always") for the Auto Attach setting and leave the "Disabled" untouched, or
• we change the semantics of the existing "Disabled" setting to not hide the status bar item. In this case we'd rely on the item's context menu to show/hide status bar items.

/cc @egamma

[connor4312]

This has been on my mine for a little while, thus done. There's a new option that disables auto attach for the "current session", which doesn't require a reload (and will only be in effect until the window is reloaded).

[weinand]

There is a new "Temporarily Disable" option in the QuickPick.

The fact that "Temporarily Disable" is only visible if auto attach is already shown in the status bar surprised me a bit. But I think the logic behind that is ok.

More problematic is that running the previous action again, does not stop the temporary disablement.
So I had "Always" enabled, and then did a "Temporarily Disable". Later I run "Always" again, but did not notice that this is ignored. All other action would actually stop the temporary disablement.
IMO this is a bug that we should fix before shipping the feature.

[weinand]

This works fine now.

But I've filed #111890

[connor4312]

Agree, I've had to point that out to users a few times.

Thanks for verifying!