Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension installation dependencies #11937

Closed
4 of 5 tasks
joaomoreno opened this issue Sep 13, 2016 · 4 comments
Closed
4 of 5 tasks

Extension installation dependencies #11937

joaomoreno opened this issue Sep 13, 2016 · 4 comments
Assignees
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Sep 13, 2016

We want to support extensions depending on other extensions and having that transitive closure installed when installing the first one. Eg. vscode-go could depend on vscode-go-syntax.

This requires vsce work:

For vscode:

We're leaving Uninstall out of the story for now.

@joaomoreno joaomoreno added feature-request Request for new features or functionality extensions Issues concerning extensions labels Sep 13, 2016
@joaomoreno joaomoreno added this to the September 2016 milestone Sep 13, 2016
@joaomoreno
Copy link
Member Author

joaomoreno commented Sep 13, 2016

@seanmcbreen @waderyan fyi

As discussed with @egamma, we're going with an approach in which 100% of this work in on our side. An extension can list other extensions it wants to be installed in the user's machine, when installing itself. As a consequence, this connection won't surface in the Marketplace, only at extension installation time, within VS Code itself.

Any other approach would require cooperation with the Marketplace to create a first class concept of extension dependencies or packs.

@waderyan
Copy link

An extension can list other extensions it wants to be installed in the user's machine, when installing itself.

Will this be done in the manifest file or where will it be done?

I am not opposed to the approach, but I can see some benefit to having dependent extensions surface in the Marketplace's UI.

@joaomoreno
Copy link
Member Author

joaomoreno commented Sep 15, 2016

We decided to use the (already existing) extensionDependencies property in package.json. It is a list of extension names.

Going with this decision won't luck us down and will let the Marketplace reflect that data in their UI, if we want to go that way in the future.

@waderyan
Copy link

Cool sounds good to me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants