Allow renaming terminal tabs inside the tab view

[Tyriar]

Terminal now:

What we want:

[Tyriar]

How explorer does it:

https://github.com/Microsoft/vscode/blob/731402dce225ce25d42a7b173361650a54bf52ad/src/vs/workbench/contrib/files/browser/fileActions.ts#L891-L922

[meganrogge]

The label becomes editable to receive text input here for the explorer

vscode/src/vs/base/browser/ui/tree/asyncDataTree.ts

Lines 934 to 952 in ef569a6

	protected render(node: IAsyncDataTreeNode<TInput, T>, viewStateContext?: IAsyncDataTreeViewStateContext<TInput, T>, options?: IAsyncDataTreeUpdateChildrenOptions<T>): void {
	const children = node.children.map(node => this.asTreeElement(node, viewStateContext));
	const objectTreeOptions: IObjectTreeSetChildrenOptions<IAsyncDataTreeNode<TInput, T>> | undefined = options && {
	...options,
	diffIdentityProvider: options!.diffIdentityProvider && {
	getId(node: IAsyncDataTreeNode<TInput, T>): { toString(): string; } {
	return options!.diffIdentityProvider!.getId(node.element as T);
	}
	}
	};
	this.tree.setChildren(node === this.root ? null : node, children, objectTreeOptions);
	if (node !== this.root) {
	this.tree.setCollapsible(node, node.hasChildren);
	}
	this._onDidRender.fire();
	}

[meganrogge]

Started work on branch merogge/edit-tab-item

[isidorn]

I actually wanted to create this identical issue, but then I remembered how many issues I got in my life because I used in the inline input box and decided that using a quick pick is actually not the worst :)
The problems with the inline quick pick is auto closing it when it loses focus, that code tends to be funky as the blur event sometimes comes a bit late. Another corner case is if you scroll out if it in the list and so on. Another corner case if you click on the + and the input box is already shown...
The UX would be nicer if the input was inline, but just be aware that I am not happy with how the code looks in the explorer.

Without further ado, here are the code pointer in how the Explorer does it:
When the + action is clicked we create a fake NewExplorerItem here
It is inserted in the model / service making everybody aware that element is in the editable mode using this method

And once the viewer detects that a item is in edit mode it actually renders the input box here
You can notice how the input box listens on all the various events on how it could possibly be closed.

So when a + is clicked the refresh of the list is necessary due to a new element. Same as when the input box is closed.

[Tyriar]

Thanks for the tips/warning