Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore extension contributions to the "New..." item #124304

Closed
miguelsolorio opened this issue May 20, 2021 · 10 comments
Closed

Explore extension contributions to the "New..." item #124304

miguelsolorio opened this issue May 20, 2021 · 10 comments
Assignees
Labels
feature-request Request for new features or functionality getting-started on-testplan ux User experience issues
Milestone

Comments

@miguelsolorio
Copy link
Contributor

miguelsolorio commented May 20, 2021

Overview

We've seen feedback from users that creating custom files, i.e. non text files like Notebooks, is difficult to find. Right now the only way to create a new custom file is through the command palette but users are not aware of this. They often looked in the menus and on the welcome page. This issue aims to address this issue.

Design

Option 1

This proposal simply appends the item under the "New File" item, because new file is for text files, and this item would be for a custom file.

image

Option 2

We could alternatively combine the items into single row if there are too many and use the split button:

image

Option 3

This would make clicking on "New File" open a quick pick with the list of options:

image

@miguelsolorio miguelsolorio added ux User experience issues getting-started labels May 20, 2021
@miguelsolorio miguelsolorio self-assigned this May 20, 2021
@miguelsolorio miguelsolorio added this to the May 2021 milestone May 24, 2021
@miguelsolorio miguelsolorio modified the milestones: May 2021, June 2021 Jun 4, 2021
@miguelsolorio
Copy link
Contributor Author

Based on discussions with the team, we'll go with the New File... pattern and introduce a new command that replaces the new file item in the getting started page and also adds it to the global File menu.

@JacksonKearl not sure if this is something that falls under your area?

@JacksonKearl
Copy link
Contributor

Yeah, that sounds neat. Though I wonder if the "new java project" should be part of something besides a "new file..." entry point. File vs Project?

@miguelsolorio
Copy link
Contributor Author

In that case we can simply do New... as a generic jump-off point for all new things regardless of type. What do you think?

@JacksonKearl JacksonKearl added the feature-request Request for new features or functionality label Jun 8, 2021
@digitarald
Copy link
Contributor

Chatting about this with @chrisdias, we should clarify that this flow both covers new file and but also new projects; so putting it all behind "New File" seems a bit confusing. One idea was to use the separators that the theme picker has to have both in one list.

@miguelsolorio
Copy link
Contributor Author

@digitarald see my comment above about combining into a New... instead (so removing "file"). Not sure whether we need a separator for projects as this would include all items and what other extensions would also use "projects"?

@digitarald
Copy link
Contributor

Ha, missed that last dialog!

Not sure whether we need a separator for projects as this would include all items and what other extensions would also use "projects"?

Java contributes a "Create New Project" and C++ is thinking about a wizard as well.

@microsoft microsoft deleted a comment from Stirfry70 Jun 10, 2021
@chrisdias
Copy link
Member

ha - i missed "project" in both lists too :)

We can probably drop the "New" from the quick pick list, its duplicative and will make it easier to scan for your favorite langauge.

@miguelsolorio miguelsolorio changed the title Explore extension contributions to the "New File..." item Explore extension contributions to the "New..." item Jun 10, 2021
JacksonKearl pushed a commit that referenced this issue Jun 18, 2021
JacksonKearl pushed a commit that referenced this issue Jun 18, 2021
@JacksonKearl
Copy link
Contributor

JacksonKearl commented Jun 18, 2021

Tried moving some of the Start entries into the "New..." item, maybe helps with clutter?

image

@miguelsolorio
Copy link
Contributor Author

I originally thought the "New" would be reserved for files and not window management. Maybe it's just me but it seems like it takes a lot more time to process the options and slows you down.

I also thought that when there are no items contributed it would be the default "New File" and when there are more items it would morph into the "New..."?

@JacksonKearl
Copy link
Contributor

JacksonKearl commented Jun 21, 2021

Agree the above is loud, but I do think there's value in bringing some of the new window commands into the spotlight... even some our own team members don't know about window duplication commands, yet window duplication is one of the most requested features of all time.

One thing that I think helps is grouping by category and removing detail text where not needed (in Insiders today), and also sorting the items so files and notebooks are at the top (currently in main):
image

(note I don't necessarily think all of those items should exist in the menu, just trying to get a feel for what the menu will look like once many extensions contribute... I made https://marketplace.visualstudio.com/items?itemName=jakearl.demo-create-new-entries to help with exploring the feel)

@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality getting-started on-testplan ux User experience issues
Projects
None yet
Development

No branches or pull requests

4 participants