Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal Editors: Add + terminal button #126256

Closed
Tyriar opened this issue Jun 14, 2021 · 2 comments · Fixed by #127120
Closed

Terminal Editors: Add + terminal button #126256

Tyriar opened this issue Jun 14, 2021 · 2 comments · Fixed by #127120
Assignees
@Tyriar @meganrogge
Labels
insiders-released Patch has been released in VS Code Insiders plan-item VS Code - planned item for upcoming terminal Integrated terminal issues terminal-editors
Milestone
June 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 14, 2021 •
edited
Loading

Sub-task of #125514

  • Split/kill?
  • Kill not needed because you can close the editor?
  • Does split apply to the terminal group or the editor group?
  • +v profile button?
@Tyriar Tyriar added plan-item VS Code - planned item for upcoming terminal Integrated terminal issues terminal-tabs labels Jun 14, 2021
@Tyriar Tyriar added this to the June 2021 milestone Jun 14, 2021
@Tyriar Tyriar self-assigned this Jun 14, 2021
@Tyriar Tyriar mentioned this issue Jun 14, 2021
Closed
27 tasks
@Tyriar Tyriar changed the title Terminal Editors: Editor actions Terminal Editors: Add + terminal button Jun 21, 2021
@Tyriar
Copy link
Member Author

Tyriar commented Jun 21, 2021

Moving split part to #126471

@Tyriar
Copy link
Member Author

Tyriar commented Jun 24, 2021

Code pointer: https://github.com/Microsoft/vscode/blob/903e219ccb8f8a0bccf8ffce33b79cb66bd9a4f4/src/vs/workbench/browser/parts/editor/titleControl.ts#L215-L215

Might not be possible yet to specify action view items

Tyriar added a commit that referenced this issue Jun 24, 2021
@Tyriar
Terminal editor + button
80d1321 
Part of #126256
This was referenced Jun 24, 2021
Merged
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
insiders-released Patch has been released in VS Code Insiders plan-item VS Code - planned item for upcoming terminal Integrated terminal issues terminal-editors
Projects
None yet
Milestone
June 2021
Development

Successfully merging a pull request may close this issue.

Terminal editor + button microsoft/vscode
3 participants
@Tyriar @meganrogge and others