Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment reactions can't load images #128770

Closed
alexr00 opened this issue Jul 15, 2021 · 1 comment
Closed

Comment reactions can't load images #128770

alexr00 opened this issue Jul 15, 2021 · 1 comment
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken verified Verification succeeded
Milestone
July 2021

Comments

@alexr00
Copy link
Member

alexr00 commented Jul 15, 2021

image

Seems like this has been lease a release or two.

When loading resources for comments I see the following error:
Not allowed to load local resource: file:///c%3A/Users/alros/.vscode/extensions/github.vscode-pull-request-github-insiders-2021.7.20703/resources/icons/reactions/laugh.png

@rebornix correctly determined that this is a file/vscode-file scheme issue.
@rebornix rebornix added regression Something that used to work is now broken bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues labels Jul 15, 2021
@rebornix rebornix added this to the July 2021 milestone Jul 15, 2021
@Sean10 Sean10 mentioned this issue Jul 24, 2021
Closed
@alexr00 alexr00 mentioned this issue Jul 27, 2021
Closed
@rebornix rebornix modified the milestones: July 2021, August 2021 Jul 28, 2021
@alexr00 alexr00 added the verified Verification succeeded label Jul 30, 2021
@alexr00
Copy link
Member Author

alexr00 commented Jul 30, 2021

Works great, thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken verified Verification succeeded
Projects
None yet
Milestone
July 2021
Development

No branches or pull requests
3 participants
@rebornix @alexr00 and others