Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Could not resolve conversation on old PR #2857

Closed
Tyriar opened this issue Jul 22, 2021 · 3 comments · Fixed by #2883
Closed

Could not resolve conversation on old PR #2857

Tyriar opened this issue Jul 22, 2021 · 3 comments · Fixed by #2883
Assignees
@alexr00
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
August 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 22, 2021

I tried to resolve this comment via the extension: xtermjs/xterm.js#3212 (comment), the reaction icon also wasn't showing:

image

ext: v2021.7.30987
Version: 1.59.0-insider (user setup)
Commit: e8a59bc6f920e731b47f0bc72263e82aba8b796e
Date: 2021-07-22T05:14:01.507Z
Electron: 13.1.7
Chrome: 91.0.4472.124
Node.js: 14.16.0
V8: 9.1.269.36-electron.0
OS: Windows_NT x64 10.0.19042
@alexr00
Copy link
Member

alexr00 commented Jul 27, 2021

Reaction not showing is microsoft/vscode#128770.

@alexr00 alexr00 self-assigned this Jul 27, 2021
@alexr00 alexr00 added this to the August 2021 milestone Jul 27, 2021
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Jul 27, 2021
@alexr00
Copy link
Member

alexr00 commented Aug 4, 2021

I think we need microsoft/vscode#130107 in order to solve this without a hack.

alexr00 added a commit that referenced this issue Aug 4, 2021
@alexr00
Could not resolve conversation on old PR
a49758f 
Fixes #2857
@alexr00 alexr00 mentioned this issue Aug 4, 2021
Merged
alexr00 added a commit that referenced this issue Aug 9, 2021
@alexr00
Could not resolve conversation on old PR (#2883)
70d39c2 
Fixes #2857
@alexr00 alexr00 mentioned this issue Aug 16, 2021
Closed
@mjbvz mjbvz added the author-verification-requested Issues potentially verifiable by issue author label Aug 26, 2021
@Tyriar Tyriar added the verified Verification succeeded label Aug 27, 2021
@alexr00 alexr00 mentioned this issue Aug 30, 2021
Closed
@eladcandroid
Copy link

I experienced it now... is there anything new?
Can you merge the last commits?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
August 2021
Development

Successfully merging a pull request may close this issue.

Could not resolve conversation on old PR microsoft/vscode-pull-request-github
4 participants
@Tyriar @mjbvz @eladcandroid @alexr00