Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug step out continues #13096

Closed
chrmarti opened this issue Sep 30, 2016 · 6 comments
Closed

Debug step out continues #13096

chrmarti opened this issue Sep 30, 2016 · 6 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone

Comments

@chrmarti
Copy link
Contributor

  • VSCode Version: Code - Insiders 1.6.0-insider (c968226, 2016-09-30T17:37:14.267Z)
  • OS Version: Windows_NT ia32 10.0.14393
  • Extensions: dbaeumer.vscode-eslint-1.0.7, eg2.tslint-0.5.39, ms-vscode.csharp-1.4.1, msjsdiag.debugger-for-chrome-0.5.2

Steps to Reproduce:

  1. In smoke-test hit breakpoint in index.js:7
  2. Step in to render()
  3. Step out
  4. Observe execution continuous instead of stepping out
@Tyriar Tyriar added the debug Debug viewlet, configurations, breakpoints, adapter issues label Oct 3, 2016
@chrmarti
Copy link
Contributor Author

chrmarti commented Nov 2, 2016

I keep running into this during the Smoke-Test. Should we add a note to it?

@weinand
Copy link
Contributor

weinand commented Nov 2, 2016

@chrmarti do you see the same behaviour with "type": "node2"?
What version of node are you using?

@chrmarti
Copy link
Contributor Author

chrmarti commented Nov 3, 2016

Yes, same with node2 using node 7.0.0. Previously with the old protocol and node 6.3.0.

@weinand
Copy link
Contributor

weinand commented Nov 3, 2016

@chrmarti OK, then this looks like a node bug.

/cc @roblourens

@chrmarti
Copy link
Contributor Author

chrmarti commented Nov 3, 2016

Also: It seems to be related to the calling function not having any further lines of actual code after the one I stepped into. We found that stepping over at the end of the stepped into function then correctly stops on the closing } of the calling function.

@weinand weinand added the bug Issue identified by VS Code Team member as probable bug label Apr 6, 2017
@weinand weinand added this to the April 2017 milestone Apr 6, 2017
@weinand
Copy link
Contributor

weinand commented Apr 21, 2017

I'm seeing the same behaviour with node-inspector.
So this is not a VS Code issue but a node bug.

@weinand weinand closed this as completed Apr 21, 2017
@weinand weinand added upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed bug Issue identified by VS Code Team member as probable bug labels Apr 21, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

3 participants