Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stepping over breakpoint appears to resume execution fully, vs stepping. #13306

Closed
cdaringe opened this issue Oct 6, 2016 · 14 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@cdaringe
Copy link

cdaringe commented Oct 6, 2016

  • VSCode Version: 1.5.3
  • OS Version: osx 10.11.6

may be related to ##13096

here, i visually demonstrate (you may want to click to view the GIF in a larger window):

stepping-over-resumes-execution mov

thanks!

@cdaringe cdaringe changed the title stepping over breakpoint appears to resumes execution fully, vs stepping. stepping over breakpoint appears to resume execution fully, vs stepping. Oct 6, 2016
@cdaringe
Copy link
Author

cdaringe commented Oct 6, 2016

it's also strange that when execution ends, the debugging bar/context remains. i would expect the debugging bar to disappear when execution finishes.

@Tyriar Tyriar added the debug Debug viewlet, configurations, breakpoints, adapter issues label Oct 6, 2016
@weinand weinand added the bug Issue identified by VS Code Team member as probable bug label Apr 6, 2017
@alecl
Copy link

alecl commented Apr 13, 2017

I've been running into this fairly often for months and it's highly frustrating. Anything that can be done to gather more info so it can be addressed?

@weinand
Copy link
Contributor

weinand commented Apr 13, 2017

What node.js version are you using?

Some version of node have a bug: see #5822
(which is due to his node bug: nodejs/node#7219)

@weinand
Copy link
Contributor

weinand commented Apr 13, 2017

@cdaringe execution of node.js does not stop because of this node bug: nodejs/node#1788

@alecl
Copy link

alecl commented Apr 13, 2017

Had the same issue in 4.5 and 6.10.1.

@alecl
Copy link

alecl commented Apr 13, 2017

Bugs in nodejs from 2 years ago. This is madness. Any suggested workaround or version that still works?

@weinand
Copy link
Contributor

weinand commented Apr 13, 2017

nodejs/node#7219 should be fixed in recent versions of node.js.

Does it help if you use the 'inspector' protocol (by addig a "protocol": "inspector" to your launch configuration?

@weinand
Copy link
Contributor

weinand commented Apr 13, 2017

I've just verified that nodejs/node#7219 was fixed for node.js >= 6.5.0

@weinand
Copy link
Contributor

weinand commented Apr 13, 2017

@alecl What VS Code version are you using?

@alecl
Copy link

alecl commented Apr 13, 2017

Interesting. I updated to 6.10.2 and then found it still happening. I set "smartStep" to false and that seemed to fix it. smartStep is skipping lines of my code that are calling outside code even though I'm NOT stepping into the outside code.

VSCode 1.11.1

@weinand
Copy link
Contributor

weinand commented Apr 13, 2017

If you still see the problem in 6.10.2 then it is unrelated to nodejs/node#7219.
Do you have any watch expressions defined? Does the problem disappear if you remove the watches?

@alecl
Copy link

alecl commented Apr 13, 2017

It still occurs if I remove the watches but I believe the issue is with the smartStep feature being enabled rather than that nodejs termination bug now that I'm on 6.10.2. I'll find/open a new issue for that. Thanks for your help.

@weinand
Copy link
Contributor

weinand commented Apr 13, 2017

@cdaringe could you please verify that your problem no longer occurs in VS Code 1.11.x and node.js >= 6.5.0 - thanks!

@cdaringe
Copy link
Author

confirmed--it's working great! thx!

@weinand weinand added this to the April 2017 milestone Apr 21, 2017
@weinand weinand added the verified Verification succeeded label Apr 21, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants