Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to split an editor into two without creating separate tabs #132651

Closed
bpasero opened this issue Sep 8, 2021 · 3 comments · Fixed by #132860
Closed

Allow to split an editor into two without creating separate tabs #132651

bpasero opened this issue Sep 8, 2021 · 3 comments · Fixed by #132860
Assignees
@bpasero
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes on-testplan plan-item VS Code - planned item for upcoming workbench-editors Managing of editor widgets in workbench window
Milestone
September 2021

Comments

@bpasero
Copy link
Member

bpasero commented Sep 8, 2021 •
edited
Loading

Extracted from #36700
@bpasero bpasero added feature-request Request for new features or functionality plan-item VS Code - planned item for upcoming workbench-editors Managing of editor widgets in workbench window labels Sep 8, 2021
@bpasero bpasero added this to the September 2021 milestone Sep 8, 2021
@bpasero bpasero self-assigned this Sep 8, 2021
This was referenced Sep 8, 2021
Open
Open
@ArturoDent
Copy link

Currently, if I Split in Group an editor and then later Join in Group that same editor tab that editor is closed - which is unexpected.

splitInGroup

Version: 1.61.0-insider (user setup)
Commit: df115e7
Date: 2021-09-08T17:51:26.439Z
Electron: 13.1.8
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.22000

bpasero added a commit that referenced this issue Sep 9, 2021
@bpasero
editors - fix side by side editor matching logic (#132651)
844aab2
@bpasero
Copy link
Member Author

bpasero commented Sep 9, 2021

@ArturoDent good catch, this took a while to fix but should be fine with 844aab2

bpasero added a commit that referenced this issue Sep 9, 2021
@bpasero
editors - fix commands for splitting/joining (#132651)
0df5af8
@bpasero bpasero mentioned this issue Sep 10, 2021
Merged
@ArturoDent
Copy link

Looks good - I can't replicate the problem anymore.

Version: 1.61.0-insider (user setup)
Commit: 0884da1
Date: 2021-09-10T08:12:39.143Z
Electron: 13.1.8
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.22000

@bpasero bpasero mentioned this issue Sep 16, 2021
Closed
@bpasero bpasero mentioned this issue Sep 24, 2021
Closed
2 tasks
@bpasero bpasero added on-testplan on-release-notes Issue/pull request mentioned in release notes labels Sep 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes on-testplan plan-item VS Code - planned item for upcoming workbench-editors Managing of editor widgets in workbench window
Projects
None yet
Milestone
September 2021
Development

Successfully merging a pull request may close this issue.

Refactor editor view state to be reusable and adopt for side by side editor microsoft/vscode
3 participants
@bpasero @ArturoDent and others