Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell integration: Setup mechanism for listening to shell integration sequences and light up capabilities #139396

Closed
Tyriar opened this issue Dec 17, 2021 · 2 comments · Fixed by #140659
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders plan-item VS Code - planned item for upcoming terminal-shell-integration Shell integration, command decorations, etc.
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 17, 2021

Parent issue #133084

The shell integration script will emit sequences that we need to handle via an xterm.js sequence handler. We may want to only light up capabilities on the terminal process once we have verified that feature works?

We also need to handle partial capabilities: On Windows may not work 100% since for example it emits the sequences in the renderer, not in the actual order they happened (microsoft/terminal#11220, microsoft/terminal#8698). Should we wait for the sequence to come and if the positioning of the prompt looks off don't turn on a particular capability?

@Tyriar Tyriar added plan-item VS Code - planned item for upcoming terminal-shell-integration Shell integration, command decorations, etc. labels Dec 17, 2021
@Tyriar Tyriar added this to the January 2022 milestone Dec 17, 2021
@microsoft microsoft deleted a comment from meganrogge Jan 4, 2022
@meganrogge
Copy link
Contributor

done here

this._register(xterm.parser.registerOscHandler(ShellIntegrationOscPs.FinalTerm, data => this._handleShellIntegration(data)));
this._register(xterm.parser.registerOscHandler(ShellIntegrationOscPs.ITerm, data => this._updateCwd(data)));

should this be closed?

@Tyriar
Copy link
Member Author

Tyriar commented Jan 13, 2022

This should be mostly done with #140635

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders plan-item VS Code - planned item for upcoming terminal-shell-integration Shell integration, command decorations, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@Tyriar @meganrogge and others