Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New move to side panel behavior - don't show again #141422

Closed
lszomoru opened this issue Jan 25, 2022 · 2 comments
Closed

New move to side panel behavior - don't show again #141422

lszomoru opened this issue Jan 25, 2022 · 2 comments
Assignees
@sbatten
Labels
invalid Issue identified as not relevant or not valid

Comments

@lszomoru
Copy link
Member

Testing #141356

As of right now the deprecation warning appears every single time one of the old commands is being invoked. While I do understand that we try to get the deprecation message across, I am wondering if the dialog should have a button for "don't show this again".
@sbatten sbatten added the under-discussion Issue is under discussion for relevance, priority, approach label Jan 25, 2022
@sbatten
Copy link
Member

sbatten commented Jan 25, 2022

My hesitation is that someone hits don't show again and eventually these commands do nothing and they are more confused. They currently have a "Don't show again" option which is to use a different key binding.

@sbatten sbatten added invalid Issue identified as not relevant or not valid and removed under-discussion Issue is under discussion for relevance, priority, approach labels Dec 29, 2022
@sbatten
Copy link
Member

sbatten commented Dec 29, 2022

we reverted all of this

@sbatten sbatten closed this as completed Dec 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

Labels
invalid Issue identified as not relevant or not valid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lszomoru @sbatten