Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: New move to side panel behavior #141356

Closed
2 tasks done
sbatten opened this issue Jan 25, 2022 · 4 comments
Closed
2 tasks done

Test: New move to side panel behavior #141356

sbatten opened this issue Jan 25, 2022 · 4 comments
Labels
testplan-item
Milestone
January 2022

Comments

@sbatten
Copy link
Member

sbatten commented Jan 25, 2022 •
edited by stevencl
Loading

Refs: #132893

Complexity: 3

Create Issue

This milestone, we will enable the side panel for stable users. This comes with quite a few changes to create a coherent experience. This item is focused on the deprecation of the old "move panel to left/right" behavior. With the new side panel, from a UX perspective, the old move panel behavior is redundant and confusing. Try out the new commands, the old commands, and review the messaging.

Test:

  1. The old commands Move Panel Left|Right|Bottom. Bind these to a shortcut to mimic an existing user of the commands.
  2. The new commands Move Views from Panel To Side Panel and Move Views from Side Panel to Panel.
  3. Review the notifications from the old commands.
  4. In your settings.json, add "workbench.panel.defaultLocation": "left" and review the deprecation messaging.
@sbatten sbatten added this to the January 2022 milestone Jan 25, 2022
@ghost ghost assigned lszomoru and stevencl Jan 25, 2022
This was referenced Jan 25, 2022
Closed
Closed
@lszomoru
Copy link
Member

@sbatten, for step 4) I have added the setting but I am not seeing any deprecation message. Am I missing something or this is a bug? If it's a bug, I will file an issue for it. Thanks!

image

This was referenced Jan 25, 2022
Closed
Closed
Closed
@lszomoru lszomoru removed their assignment Jan 25, 2022
@sbatten
Copy link
Member Author

sbatten commented Jan 25, 2022

@lszomoru it renders in the settings editor

@roblourens do we not render deprecation in the json view?

@stevencl stevencl mentioned this issue Jan 26, 2022
Closed
@stevencl
Copy link
Member

I can see the deprecation message in the json view:

image

@stevencl stevencl removed their assignment Jan 26, 2022
@lszomoru
Copy link
Member

In today's build I am also seeing the deprecation. It was not there in yesterday's build 🤷🏻‍♂️

@sbatten sbatten closed this as completed Jan 26, 2022
br3ndonland added a commit to br3ndonland/dotfiles that referenced this issue Feb 5, 2022
@br3ndonland
Remove VSCode workbench.panel.defaultLocation
e02b810 
VSCode 1.64 info notice in settings.json:

> This setting has been deprecated with the addition of the new side
> panel. Instead of setting the location for the panel, you now use
> the "Move Views" commands to set the location of the individual view
> containers within the panels.

Another questionable VSCode "feature":

microsoft/vscode#132893
microsoft/vscode#141349
microsoft/vscode#141356

Other integrated terminal fixes and "features" I've had to disable:

- Terminal tabs:
  - 23e32a2
  - 4813726
- Rearranging `$PATH`: 3ca8e2c
- Breaking forward delete word: a71fdc7
- Enabling persistent terminal sessions: d895455
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
testplan-item
Projects
None yet
Milestone
January 2022
Development

No branches or pull requests
3 participants
@stevencl @lszomoru @sbatten