File nesting: Improve file icon rendering for folder less themes

[aeschli]

Testing #141354

• set "explorer.experimental.fileNesting.enabled": true
• open a folder with foo.js and foo.ts
• use the Seti file icon theme
  

Theres a misalignment as the Seti theme doesn't expect that a file can be a root node.
We probably have to hide the icon of foo.ts

[JacksonKearl]

cc @misolori any ideas on how this could look? I like how the icon lets me know it's a file, but agree the alignment is weird.

[miguelsolorio]

I'd probably hide the file icon for the parent folder, even though it isn't ideal but you can't get alignment and folder icon unless we add a folder icon for seti icons:

[chrisdias]

with the minimal file icon theme, the nested files are indented nicely

As compared to seti...

[JacksonKearl]

I'll try to find a way to make Seti work well next iteration, I'd rather not lose the quick identifiability the icons provide but agree the current alignment is very odd

[aeschli]

@JacksonKearl Happy to help and review.
align-icons-and-twisties is the css rule that is set when a file icon theme only defines file icons but no folder icons.

[aeschli]

There are also file icon themes that disable the twisties. Instead, they provide different folder icons for expanded and collapsed folders.
An example is the Ayu theme:

Again such themes don't work well with file nesting

I can open a different issue for that.

[yume-chan]

There are also file icon themes that disable the twisties. Instead, they provide different folder icons for expanded and collapsed folders.

#141359

[miguelsolorio]

Another idea that came from the ux sync was aligning the other files to the same indentation in the case where there is no folder icon (like seti) and since they are not sibilings they should be on the same indentation:

Since we already make adjustments when either there is a folder chevron or folder icon, we should be able to make adjustment based on these options + file nesting is enabled

[babakfp]

Hi @JacksonKearl
I see you are working on this feature. What do you think about a config (for each pattern) that disables the ability to hide the nested files (child files)? So they can always be visible and accessible. I see that it can be a useful feature to add. For example, this is what it is right now:

... and this is how I want it to be:

---

Also, an option for each pattern to hide the child file icon if its name was equal to the parent file name or something like that.

[JacksonKearl]

@babakfp by default all nests are shown expanded, I don't see why we'd want to remove the option of collapsing them?

[babakfp]

Hi
Thank you for your response

by default all nests are shown expanded, I don't see why we'd want to remove the option of collapsing them?

It's because of this problem and reasons👇
#141359

• So I can have peace of mind that there are no hidden files.
• Some people may disable the whole nesting feature because they don't want this problem file nesting: impossible to discover nested files if icon theme hides folder arrows #141359 to happen to them.

Thank you again. A saw a lot of issues assigned to you, here is a coffee🍵😅🌸

@JacksonKearl

[JacksonKearl]

#141359 is definitely a bug, but it only appears when the file icon theme has disabled folder chevrons. I will be fixing that this iteration by rendering nests with chevrons regardless of whether they're rendered with folders.

[JacksonKearl]

We now hide the icon of a nest parent if the folders do not have chevrons or icons

[babakfp]

I will be fixing that this iteration by rendering nests with chevrons regardless of whether they're rendered with folders.

But it's not the same. There is an option to hide the 'angle down/arrow down' icon, so it means that there was/is a need for this option/this functionality. By doing what you said, you are destroying that functionality!

We now hide the icon of a nest parent if the folders do not have chevrons or icons

What do you mean is that this (TS) icon is going to be hidden?:

It's not a good thing to do if it's not optional for each nest. (Maybe I misunderstood what you meant)

@JacksonKearl

[JacksonKearl]

That is what I have now, though I can see the sense in doing this instead.

[babakfp]

That is what I have now, though I can see the sense in doing #141428 (comment) instead.

Yeah, in my opinion, this one is better than removing the icon.

It's also useful to only group files together(for ordering porpuses) instead of nesting them under each other.