Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine tune when shell integration activation message is shown #141483

Closed
meganrogge opened this issue Jan 25, 2022 · 3 comments · Fixed by #142228
Closed

Fine tune when shell integration activation message is shown #141483

meganrogge opened this issue Jan 25, 2022 · 3 comments · Fixed by #142228
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. ux User experience issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@meganrogge
Copy link
Contributor

meganrogge commented Jan 25, 2022

This will be particularly important when we enable this by default

One option:

  • only show it in the first x terminals created of a particular shell
@meganrogge meganrogge added this to the February 2022 milestone Jan 25, 2022
@meganrogge meganrogge added polish Cleanup and polish issue terminal-shell-integration Shell integration, command decorations, etc. labels Jan 25, 2022
@Tyriar
Copy link
Member

Tyriar commented Jan 25, 2022

Good topic for UX sync, some other ideas:

  • Dismiss by hovering the message
  • Status bar entry calling out shell integration

@Tyriar Tyriar added the ux User experience issues label Jan 25, 2022
@meganrogge meganrogge changed the title Only show Shell integration activated! message in first x terminals created of a particular shell Fine tune when shell integration activation message is shown Jan 25, 2022
Tyriar added a commit to microsoft/vscode-docs that referenced this issue Feb 4, 2022
Tyriar added a commit that referenced this issue Feb 4, 2022
Tyriar added a commit that referenced this issue Feb 4, 2022
Tyriar added a commit that referenced this issue Feb 4, 2022
Tyriar added a commit that referenced this issue Feb 4, 2022
@Tyriar
Copy link
Member

Tyriar commented Feb 4, 2022

The message is still there but is now a link to the docs with an action to flip a setting:
Screen Shot 2022-02-04 at 2 40 21 pm

@Tyriar Tyriar added feature-request Request for new features or functionality and removed polish Cleanup and polish issue labels Feb 4, 2022
@Tyriar
Copy link
Member

Tyriar commented Feb 4, 2022

To verify make sure the link's hover and its links work, even when the link wraps the line in a really narrow terminal.

@Tyriar Tyriar added the verification-needed Verification of issue is requested label Feb 4, 2022
@rzhao271 rzhao271 added the verified Verification succeeded label Feb 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. ux User experience issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@Tyriar @rzhao271 @meganrogge and others