Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension readme in product does not support markdown reference links #142003

Closed
Tyriar opened this issue Feb 2, 2022 · 2 comments · Fixed by #149729
Closed

Extension readme in product does not support markdown reference links #142003

Tyriar opened this issue Feb 2, 2022 · 2 comments · Fixed by #149729
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders markdown Markdown support issues upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Milestone
May 2022

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 2, 2022

Markdown:

| Project | License | Reason
|---------|---------|--------
| [pako]  | [MIT][pako_MIT] and [Zlib][pako_Zlib] | Used to decompress png datastreams

[pako]: https://www.npmjs.com/package/pako
[pako_MIT]: https://github.com/nodeca/pako/blob/master/LICENSE
[pako_Zlib]: https://github.com/nodeca/pako/blob/master/lib/zlib/README

Editor:
image

In extension view:
image

I can obviously workaround this but it's pretty ugly:
image

I'm not sure if the marketplace supports this or not as I didn't publish it.
@mjbvz
Copy link
Collaborator

mjbvz commented Feb 2, 2022 •
edited
Loading

Looks like a potential bug with marked: demo

Works fine with markdown-it

@mjbvz
Copy link
Collaborator

mjbvz commented Feb 2, 2022

Looks like this is being tracked by markedjs/marked#2217

Will keep this open to track picking up new marked version

@mjbvz mjbvz added this to the Backlog milestone Feb 2, 2022
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues labels Feb 2, 2022
@sandy081 sandy081 removed their assignment Feb 8, 2022
@mjbvz mjbvz added the upstream-issue-linked This is an upstream issue that has been reported upstream label Feb 28, 2022
@mjbvz mjbvz modified the milestones: Backlog, May 2022 May 17, 2022
mjbvz added a commit to mjbvz/vscode that referenced this issue May 17, 2022
@mjbvz
Pick up latest Marked.js release
631d0ca 
Fixes microsoft#142003
@mjbvz mjbvz mentioned this issue May 17, 2022
Merged
mjbvz added a commit that referenced this issue May 17, 2022
@mjbvz
Pick up latest Marked.js release (#149729)
9ae563f 
Fixes #142003
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label May 17, 2022
wannieman98 pushed a commit to wannieman98/vscode that referenced this issue May 17, 2022
@mjbvz @wannieman98
Pick up latest Marked.js release (microsoft#149729)
f91c561 
Fixes microsoft#142003
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 18, 2022
@joyceerhl joyceerhl added the verified Verification succeeded label Jun 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders markdown Markdown support issues upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Projects
None yet
Milestone
May 2022
Development

Successfully merging a pull request may close this issue.

Pick up latest Marked.js release mjbvz/vscode
5 participants
@Tyriar @sandy081 @mjbvz @joyceerhl @vscodenpa