Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language specific default overrides not marked in settings UI #145719

Closed
isidorn opened this issue Mar 22, 2022 · 2 comments
Closed

Language specific default overrides not marked in settings UI #145719

isidorn opened this issue Mar 22, 2022 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) settings-editor VS Code settings editor issues

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 22, 2022

Testing #145588

  1. Settings UI, open Workspace tab
  2. Search for @lang:markdown wordwrap
  3. Notice how the wordwrap appears as not changed (no blue line) -> 🐛

wordwrap should be rendered as modified since none of my workspace settings actually change the word wrap value, and the markdown default value should take precedence here.

fyi @sandy081

Screenshot 2022-03-22 at 15 09 39

@isidorn isidorn added the settings-editor VS Code settings editor issues label Mar 22, 2022
@rzhao271
Copy link
Contributor

If the default value has been overridden by the markdown language/extension, there should be a badge, or some text. That part is a bug.
I'm not sure about showing a blue line, though, because to me that means the workspace-scope setting value has been manually configured.

@rzhao271 rzhao271 added the bug Issue identified by VS Code Team member as probable bug label Mar 22, 2022
@rzhao271 rzhao271 modified the milestones: March 2022, April 2022 Mar 22, 2022
@rzhao271 rzhao271 changed the title Language specific overrides not marked in workspace tab of settings UI Language specific default overrides not marked in settings UI Apr 21, 2022
@rzhao271 rzhao271 modified the milestones: April 2022, May 2022 Apr 21, 2022
@rzhao271
Copy link
Contributor

rzhao271 commented May 3, 2022

Tracking in #148672. We already have default override indicators for when an extension contributes a non-language-specific setting default value override, but we currently don't have them for extension-contributed language-specific setting default value overrides.

@rzhao271 rzhao271 closed this as completed May 3, 2022
@rzhao271 rzhao271 removed this from the May 2022 milestone May 3, 2022
@isidorn isidorn added *duplicate Issue identified as a duplicate of another issue(s) and removed bug Issue identified by VS Code Team member as probable bug labels Jun 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) settings-editor VS Code settings editor issues
Projects
None yet
Development

No branches or pull requests

2 participants