Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for language-specific default override indicators #148672

Closed
rzhao271 opened this issue May 3, 2022 · 0 comments · Fixed by #149294
Closed

Improve support for language-specific default override indicators #148672

rzhao271 opened this issue May 3, 2022 · 0 comments · Fixed by #149294
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders settings-editor VS Code settings editor issues verified Verification succeeded
Milestone

Comments

@rzhao271
Copy link
Contributor

rzhao271 commented May 3, 2022

Ref #131707

There is currently an issue in the configuration service that prevents us from reliably identifying which extension contributed a language-specific default override.

  1. In a sample extension, change its contributes.configurationDefaults such that it contributes a language-specific default override.
  2. Run the extension and search for the language-specific setting that is overridden. Remember to use a language filter.
  3. The default override indicator does not show up in that view.

Note that the default override indicator is scope-specific. When an extension overrides the default of a language-specific setting, when viewing the non-language-specific equivalent of the setting, my current belief is the default override indicator should not show up.

@rzhao271 rzhao271 added this to the May 2022 milestone May 3, 2022
@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues labels May 3, 2022
@sandy081 sandy081 removed their assignment May 11, 2022
rzhao271 added a commit that referenced this issue May 11, 2022
This PR adds a default override indicator to extension-contributed
language-specific default setting overrides.
rzhao271 added a commit that referenced this issue May 18, 2022
This PR adds a default override indicator to extension-contributed
language-specific default setting overrides.
rzhao271 added a commit that referenced this issue May 19, 2022
This PR adds a default override indicator to extension-contributed
language-specific default setting overrides.
rzhao271 added a commit that referenced this issue May 19, 2022
* Add indicator, fixes #148672

This PR adds a default override indicator to extension-contributed
language-specific default setting overrides.

* Remove indicator from language tag settings
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 19, 2022
@mjbvz mjbvz added the verified Verification succeeded label Jun 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants