Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saving a large file says running TS/JS formatter, clicking configure says it's disabled #152354

Closed
Tyriar opened this issue Jun 16, 2022 · 4 comments
Closed

Saving a large file says running TS/JS formatter, clicking configure says it's disabled #152354

Tyriar opened this issue Jun 16, 2022 · 4 comments
Assignees
@rzhao271
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 16, 2022 •
edited
Loading

Repro:

  1. Open bundled workbench.desktop.main.js
  2. Save, the formatter progress notification shows
  3. Click configure
  4. Settings show up and say it's disabled?

image

This didn't happen every time I tried to save 🤷
@jrieken
Copy link
Member

jrieken commented Jun 17, 2022

@Tyriar is this in the vscode repo? there we have a workspace setting to enable formatting on save

@Tyriar
Copy link
Member Author

Tyriar commented Jun 17, 2022

I had microsoft/vscode open but the file was C:\Users\Daniel\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\workbench.desktop.main.js. After looking at settings a little deeper this appears to be a problem in the settings UI:

image

image

image

@Tyriar Tyriar assigned rzhao271 and unassigned jrieken and mjbvz Jun 17, 2022
@rzhao271
Copy link
Contributor

rzhao271 commented Jun 17, 2022 •
edited
Loading

Is the problem that the Settings editor isn't showing that there are language overrides, or is the problem that the extension link didn't redirect to a query with the language filter? The first issue is tracked at #145731

@rzhao271 rzhao271 added the info-needed Issue requires more information from poster label Jun 17, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Jun 17, 2022

It's #145731 👍 thought it had already made it in

@Tyriar Tyriar closed this as completed Jun 17, 2022
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Jun 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzhao271 rzhao271

Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jrieken @Tyriar @rzhao271 @mjbvz