Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate if setting has a language-specific value #145731

Closed
joyceerhl opened this issue Mar 22, 2022 · 3 comments · Fixed by #153041
Closed

Indicate if setting has a language-specific value #145731

joyceerhl opened this issue Mar 22, 2022 · 3 comments · Fixed by #153041
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan settings-editor VS Code settings editor issues
Milestone

Comments

@joyceerhl
Copy link
Contributor

joyceerhl commented Mar 22, 2022

Testing #145588

Introduce an indicator when a setting has language specific value when viewing that setting in non-language specific scope.

For example

  1. Filter to @lang:css
  2. Change a setting
  3. Remove filter
  4. Search for that setting
  5. There's no indication that the setting's value has changed for the current scope ('User') and also there is a language overriding this value.

image

Also same if the setting has a different value for other languages contributed in defaults

@joyceerhl joyceerhl changed the title No indication that a setting has been overridden in language-specific settings No indication that a setting has been overridden by user in language-specific settings Mar 22, 2022
@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues labels Mar 22, 2022
@rzhao271 rzhao271 added this to the April 2022 milestone Mar 22, 2022
@rzhao271
Copy link
Contributor

The lack of a modified filter is intentional, but imo there should at least be text saying that the setting has been overridden for some languages.
Adding to next milestone.

@rzhao271 rzhao271 modified the milestones: April 2022, May 2022 Apr 21, 2022
@rzhao271 rzhao271 changed the title No indication that a setting has been overridden by user in language-specific settings No override indicator in user scope for a setting that has a language-specific value Apr 21, 2022
@sandy081 sandy081 added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels May 9, 2022
@sandy081 sandy081 self-assigned this May 10, 2022
@sandy081 sandy081 changed the title No override indicator in user scope for a setting that has a language-specific value No indicator for a setting that has a language-specific value May 10, 2022
@sandy081 sandy081 changed the title No indicator for a setting that has a language-specific value Indicate if setting has a language-specific value May 10, 2022
@sandy081
Copy link
Member

@rzhao271 and myself discussed on this and decided to introduce some minimal UI when the setting has language specific values when shown in non-language specific scope. UI includes text as follows:

Other languages have overridden this setting.

languages shall be rendered as link, clicking on it shows the list of languages overriding the setting. Selecting the language shall apply language and setting filter in the search box.

@heartacker
Copy link
Contributor

hi all, I think that will be great to show the language-specific value-item if there are.
image

@rzhao271 rzhao271 mentioned this issue Jun 23, 2022
6 tasks
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jun 24, 2022
@vscodenpa vscodenpa removed the unreleased Patch has not yet been released in VS Code Insiders label Jun 27, 2022
@vscodenpa vscodenpa added the insiders-released Patch has been released in VS Code Insiders label Jun 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan settings-editor VS Code settings editor issues
Projects
None yet
5 participants