Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful disconnect to remote Management Host #173602

Open
MarkZuber opened this issue Feb 6, 2023 · 0 comments
Open

Graceful disconnect to remote Management Host #173602

MarkZuber opened this issue Feb 6, 2023 · 0 comments
Assignees
Labels
remote-connection Issues about the remote connection under-discussion Issue is under discussion for relevance, priority, approach

Comments

@MarkZuber
Copy link
Contributor

During a remote connection, if the client closes gracefully, the closing message doesn't necessarily reach the Management host since the message is sent async. So the Management host sticks around expecting the possibility of a reconnection that isn't going to happen, because if the client window is fully closed then they'll do a full connection flow the next time they connect instead of a reconnect. If the disconnect message is not received by the Management host in vscode-server, then it hangs around for a long time and consumes remote resources.

During the window close / disconnect we want to ensure the message is sent immediately to the Management host before shutdown so that the Management host can fully close properly.

@joyceerhl joyceerhl assigned alexdima and unassigned joyceerhl Feb 16, 2023
@alexdima alexdima added remote-connection Issues about the remote connection under-discussion Issue is under discussion for relevance, priority, approach labels Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
remote-connection Issues about the remote connection under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

5 participants