Graceful disconnect to remote Management Host #173603
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #173602
This PR adds a sendDisconnectAndWait() method to the PersistentProtocol class that calls through to the ProtocolWriter with a new WriteImmediately() method to send the disconnect message from the client synchronously during client shutdown. This ensures the Management connection gets the disconnect message which could be lost of the protocol doesn't flush all messages to the server.
@alexdima - As we discussed earlier, it would be great to get an integration test in place for this. I wasn't clear on where would be the best place to write an integraiton test and control the app shutdown as well as verifying that the message made its way to the server behind the test resolver. Let me know if you have a pointer to an existing test I could use as a reference or if we need to create something new.